Skip to content

@W-21557588 2pp review #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joroscoSF merged 4 commits into from
Mar 25, 2026
Merged

@W-21557588 2pp review #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96005b9
fix: license, dev-scripts, deps
iowillhoit Mar 24, 2026
437c602
Merge branch 'main' into ew/review
iowillhoit Mar 24, 2026
4a7a659
chore: merge main
iowillhoit Mar 25, 2026
3c7842d
chore: add comment back
iowillhoit Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
module.exports = {
extends: ['eslint-config-salesforce-typescript', 'plugin:sf-plugin/recommended'],
extends: ['eslint-config-salesforce-typescript', 'eslint-config-salesforce-license', 'plugin:sf-plugin/recommended'],
root: true,
rules: {
header: 'off',
},
};
2 changes: 2 additions & 0 deletions .github/workflows/onRelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,7 @@ jobs:
with:
tag: ${{ needs.getDistTag.outputs.tag || 'latest' }}
githubTag: ${{ github.event.release.tag_name || inputs.tag }}
ctc: true
sign: true

secrets: inherit
20 changes: 10 additions & 10 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ on:
jobs:
unit-tests:
uses: salesforcecli/github-workflows/.github/workflows/unitTest.yml@main
nuts:
needs: unit-tests
uses: salesforcecli/github-workflows/.github/workflows/nut.yml@main
secrets: inherit
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
fail-fast: false
with:
os: ${{ matrix.os }}
# nuts:
# needs: unit-tests
# uses: salesforcecli/github-workflows/.github/workflows/nut.yml@main
# secrets: inherit
# strategy:
# matrix:
# os: [ubuntu-latest, windows-latest]
# fail-fast: false
# with:
# os: ${{ matrix.os }}
8 changes: 2 additions & 6 deletions .nycrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
{
"check-coverage": true,
"lines": 75,
"statements": 75,
"functions": 75,
"branches": 75
}
"extends": "@salesforce/dev-config/nyc"
Copy link
Contributor Author

@iowillhoit iowillhoit Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is default config. Unless there is a good reason to change it, I would leave it

Copy link
Contributor

@joroscoSF joroscoSF Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

}
3 changes: 1 addition & 2 deletions LICENSE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Apache License Version 2.0

Copyright (c) 2024 Salesforce, Inc.
Copyright (c) 2026 Salesforce, Inc.
All rights reserved.

Apache License
Expand Down Expand Up @@ -204,4 +204,3 @@ All rights reserved.
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# plugin-data-code-extension

[![NPM](https://img.shields.io/npm/v/@salesforce/plugin-data-code-extension.svg?label=@salesforce/plugin-data-code-extension)](https://www.npmjs.com/package/@salesforce/plugin-data-code-extension) [![Downloads/week](https://img.shields.io/npm/dw/@salesforce/plugin-data-code-extension.svg)](https://npmjs.org/package/@salesforce/plugin-data-code-extension) [![License](https://img.shields.io/badge/License-BSD%203--Clause-brightgreen.svg)](https://raw.githubusercontent.com/salesforcecli/@salesforce/plugin-data-code-extension/main/LICENSE.txt)
[![NPM](https://img.shields.io/npm/v/@salesforce/plugin-data-code-extension.svg?label=@salesforce/plugin-data-code-extension)](https://www.npmjs.com/package/@salesforce/plugin-data-code-extension) [![Downloads/week](https://img.shields.io/npm/dw/@salesforce/plugin-data-code-extension.svg)](https://npmjs.org/package/@salesforce/plugin-data-code-extension) [![License](https://img.shields.io/badge/License-Apache--2.0-blue.svg)](https://opensource.org/license/apache-2-0)

# Description

Expand Down
253 changes: 0 additions & 253 deletions how_to_license.md
View file
Open in desktop

This file was deleted.

22 changes: 12 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,22 @@
"version": "1.0.0",
"dependencies": {
"@oclif/core": "^4",
"@salesforce/core": "^8",
"@salesforce/core": "^8.2.7",
"@salesforce/sf-plugins-core": "^12"
},
"devDependencies": {
"@oclif/plugin-command-snapshot": "^5.1.9",
"@salesforce/cli-plugins-testkit": "^5.3.10",
"@salesforce/dev-scripts": "^10",
"eslint-plugin-sf-plugin": "^1.18.6",
"@oclif/plugin-command-snapshot": "^5.2.3",
"@salesforce/cli-plugins-testkit": "^5.3.20",
"@salesforce/dev-scripts": "^11.0.4",
Copy link
Contributor Author

@iowillhoit iowillhoit Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped dev-scripts to 11.0.4 and ran yarn. It bumped all of the other dependencies and devDependencies (as designed)

Copy link
Contributor

@joroscoSF joroscoSF Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed dependabot complaining and I'd imagine this will squelch most of that. Was wondering and now I know.

"eslint-plugin-sf-plugin": "^1.18.8",
"oclif": "^4.14.0",
"ts-node": "^10.9.2",
"typescript": "^5.4.5"
"typescript": "^5.5.4"
},
"engines": {
"node": ">=18.0.0"
},
"repository": "salesforcecli/plugin-data-code-extension",
"files": [
"/lib",
"/messages",
Expand All @@ -34,7 +35,7 @@
"sfdx",
"sfdx-plugin"
],
"license": "BSD-3-Clause",
"license": "Apache-2.0",
"oclif": {
"commands": "./lib/commands",
"bin": "sf",
Expand Down Expand Up @@ -63,14 +64,15 @@
"clean-all": "sf-clean all",
"compile": "wireit",
"docs": "sf-docs",
"fix-license": "eslint src test --fix --rule \"header/header: [2]\"",
Copy link
Contributor Author

@iowillhoit iowillhoit Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by dev-scripts. Running this fixes/adds the license headers

Copy link
Contributor

@joroscoSF joroscoSF Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more you know

"format": "wireit",
"link-check": "wireit",
"lint": "wireit",
"postinstall": "node -e \"const r=require('child_process').spawnSync('./node_modules/.bin/husky',['install'],{stdio:'inherit'});if(r.error&&r.error.code!=='ENOENT')process.exit(1);\"",
Copy link
Contributor Author

@iowillhoit iowillhoit Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this came from? I deleted it in favor of "prepare": "sf-install", <-- this is what hooks into dev-scripts to make a bunch of changes to keep everything in sync

"postpack": "sf-clean --ignore-signing-artifacts",
"prepack": "sf-prepack",
"prepare": "sf-install",
"test": "wireit",
"test:nuts": "node scripts/run-nuts.cjs",
"test:nuts": "nyc mocha \"**/*.nut.ts\" --slow 4500 --timeout 600000 --parallel",
Copy link
Contributor Author

@iowillhoit iowillhoit Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this "do NUT tests exists script" and just commented out the lines in the tests.yml Github Action above. If you feel strongly about this, you can add it back

Copy link
Contributor

@joroscoSF joroscoSF Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel strongly about learning the proper/accepted way of doing things on my Typescript voyage.

"test:only": "wireit",
"version": "oclif readme"
},
Expand Down Expand Up @@ -179,7 +181,7 @@
"output": []
},
"link-check": {
"command": "node -e \"process.exit(process.env.CI ? 0 : 1)\" || linkinator \"**/*.md\" --skip \"CHANGELOG.md|node_modules|test/|confluence.internal.salesforce.com|my.salesforce.com|%s\" --markdown --retry --directory-listing --verbosity error",
"command": "node -e \"process.exit(process.env.CI ? 0 : 1)\" || linkinator \"**/*.md\" --skip \"CHANGELOG.md|node_modules|test/|confluence.internal.salesforce.com|my.salesforce.com|localhost|%s\" --markdown --retry --directory-listing --verbosity error",
"files": [
"./*.md",
"./!(CHANGELOG).md",
Expand Down
Loading
Loading