Fail springboot builds when their validation checks fail #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @thirtyseven to sign the Salesforce Inc. Contributor License Agreement. |
…ecks fail Add comment Fix filenames
Contributor
|
@thirtyseven sorry for the delay on this. A contribution (not yours) since 2.6.3 breaks our internal monorepo, and I just haven't had time to sort out the solution. I am trying to get through it this weekend. |
Author
|
No worries! This is technically a breaking change too, although I’d imagine for most users a welcome one. Should it be gated behind an attr and/or a CLI flag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a _validation output group to the springboot rule that includes the outputs of dupecheck, javaxdetect and banneddeps. This ensures that the springboot build fails when these checks fail.
The PR also changes the generated validation files to have unique filenames. This addresses some cases for "multiple springboot rules in the same package" that were not handled in #139.