Skip to content

Conversation

@MatthewJuliusScott
Copy link

No description provided.

@salesforce-cla
Copy link

salesforce-cla bot commented Mar 2, 2022

Thanks for the contribution! Unfortunately we can't verify the commit author(s): matthewscott <m***@h***.c***.au>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

Copy link
Author

@MatthewJuliusScott MatthewJuliusScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@eperret eperret self-requested a review March 2, 2022 19:28
Copy link
Member

@eperret eperret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatthewJuliusScott can you separate the formatting changes from the windows 10 changes? Currently, it is hard to tell which changes are important.

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @MatthewJuliusScott to sign the Salesforce.com Contributor License Agreement.

@eperret
Copy link
Member

eperret commented Jan 27, 2026

Thanks for the contribution! Before we can merge this, we need @MatthewJuliusScott to sign the Salesforce.com Contributor License Agreement.

@MatthewJuliusScott can you sign the CLA?

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java-version>16</java-version>
Copy link
Member

@eperret eperret Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this JDK 17? 17 is a long term support version and will have better compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants