Port EmbedLite components to ESR115#108
Open
abranson wants to merge 6 commits into
Open
Conversation
Member
abranson
commented
May 22, 2026
- Port EmbedLite JS components and frame-script helpers to ESR115 APIs.
- Drop obsolete prompt, web app install, and JSON tap-handler glue.
- Prepare JS components for static registration and fix startup/export handling.
- Update error-page branding to use Sailfish Browser.
- Fix ESR115 follow-ups for search initialization, HTTP auth password saving, async clipboard paste prompts, and PDF saver print settings.
5bf779a to
2930466
Compare
rainemak
reviewed
May 27, 2026
rainemak
reviewed
May 27, 2026
| ChromeUtils.import("chrome://embedlite/content/sync/bookmarks.js"); | ||
| return true; | ||
| } catch (e) { | ||
| Logger.warn("Firefox Sync API is not available", e); |
Member
There was a problem hiding this comment.
I don't see this immediately. Why this message is related to the Firefox Sync API.
rainemak
reviewed
May 27, 2026
rainemak
reviewed
May 27, 2026
rainemak
reviewed
May 27, 2026
rainemak
reviewed
May 27, 2026
rainemak
reviewed
May 27, 2026
| Name: embedlite-components-qt5 | ||
| Summary: EmbedLite components Qt5 | ||
| Version: 1.23.0 | ||
| Version: 1.26.0 |
Update frame scripts and JS components for ESR115 module and service API changes. Drop obsolete JSON tap handlers and legacy prompt/web app component glue. Register EmbedLite JS components statically and preserve helper exports when scripts are loaded as subscripts.
Respond to explicit search init requests from the embedder and use Services.search.setDefault when changing the selected search engine.
Route HTTP auth prompts through EmbedLite directly so the remember-password checkbox is included in the prompt payload. ESR115's nsIPromptService.asyncPromptAuth does not carry checkLabel/checkValue, so the password manager never saw a save request.
Add a frame-script helper for async clipboard read prompts and register it with the embed helper. Use the requesting window when prompting so permission decisions are scoped to the correct browser window.
2930466 to
30817ff
Compare
rainemak
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.