Skip to content

Cash payouts auto funding#478

Open
Zach Harrison (zachharrison) wants to merge 29 commits intomasterfrom
cash-payouts-auto-funding
Open

Cash payouts auto funding#478
Zach Harrison (zachharrison) wants to merge 29 commits intomasterfrom
cash-payouts-auto-funding

Conversation

@zachharrison
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

Copilot AI review requested due to automatic review settings January 28, 2026 17:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements cash payout auto-funding functionality by introducing a new "PROCESSING" status for rewards and referrals that are awaiting scheduled payout. The changes update status handling logic, add new status display components, and reorganize story files to separate tax-and-cash-specific examples from general reward flows.

Changes:

  • Added PROCESSING status to handle rewards with scheduled future payouts
  • Updated status determination logic to check dateScheduled against current time
  • Created separate story files for tax-and-cash scenarios

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/mint-components/src/components/sqm-stencilbook/sqm-stencilbook.tsx Added imports for new tax-and-cash story files and swapped import paths for existing stories
packages/mint-components/src/components/sqm-rewards-table/cells/sqm-rewards-table-status-cell.tsx Added PROCESSING status with date-based logic and updated status determination to check dateScheduled
packages/mint-components/src/components/sqm-rewards-table/cells/readme.md Updated documentation for new payoutProcessing prop and revised payoutApproved text
packages/mint-components/src/components/sqm-rewards-table/TaxAndCashRewardsTableCell.stories.tsx New story file demonstrating various tax-and-cash reward status cells
packages/mint-components/src/components/sqm-rewards-table/TaxAndCashRewardsTable.stories.tsx New story file showing complete tax-and-cash rewards table
packages/mint-components/src/components/sqm-rewards-table/RewardsTableCell.stories.tsx Removed tax-related status exports and added cash reward data
packages/mint-components/src/components/sqm-rewards-table/RewardsTable.stories.tsx Removed tax-and-cash-specific story rows
packages/mint-components/src/components/sqm-referral-table/cells/sqm-referral-table-rewards-cell.tsx Added PROCESSING status with similar date-based logic and updated status text templates
packages/mint-components/src/components/sqm-referral-table/TaxAndCashReferralTableRewardsCell.stories.tsx New story file for tax-and-cash referral table reward cells
packages/mint-components/src/components/sqm-referral-table/TaxAndCashReferralTable.stories.tsx New story file for complete tax-and-cash referral table
packages/mint-components/package.json Version bump to 2.0.10-0
Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| `payoutApproved` | `payout-approved` | | `string` | `"Payout approved and scheduled for payment based on your settings."` |
| `payoutCancelled` | `payout-cancelled` | | `string` | `"If you think this is a mistake, contact our Support team."` |
| `payoutFailed` | `payout-failed` | | `string` | `"Payout failed due to a fulfillment issue and is current being retried."` |
| `payoutProcessing` | `payout-processing` | | `string` | `"Processing until {date}. Payout is then scheduled based your settings."` |
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing article 'on' before 'your settings'. Should be 'based on your settings'.

Suggested change
| `payoutProcessing` | `payout-processing` | | `string` | `"Processing until {date}. Payout is then scheduled based your settings."` |
| `payoutProcessing` | `payout-processing` | | `string` | `"Processing until {date}. Payout is then scheduled based on your settings."` |

Copilot uses AI. Check for mistakes.
…s/sqm-rewards-table-status-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 30, 2026 18:43
…s/sqm-rewards-table-status-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ls/sqm-referral-table-rewards-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ls/sqm-referral-table-rewards-cell.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 6, 2026 00:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

packages/mint-components/src/components/sqm-referral-table/cells/sqm-referral-table-rewards-cell.tsx:1

  • Corrected spelling from 'based your' to 'based on your' (appears twice in the PAYOUT_APPROVED and PROCESSING messages).
import { Component, h, Prop } from "@stencil/core";

packages/mint-components/src/components/sqm-referral-table/cells/sqm-referral-table-rewards-cell.tsx:1

  • Inconsistent variable usage - the condition uses partnerFundsStatus in some checks and partnerTransferStatus in others, but these reference the same value. Use the same variable name throughout for consistency.
import { Component, h, Prop } from "@stencil/core";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 121 to 123
(reward.partnerFundsTransfer.dateScheduled < Date.now() &&
partnerTransferStatus !== "OVERDUE" &&
partnerTransferStatus !== "REVERSED")
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition checks for dateScheduled < Date.now() combined with status exclusions, but this logic seems incomplete. If the scheduled date has passed and the status is not OVERDUE or REVERSED, this falls through to PAYOUT_APPROVED. Consider adding a comment explaining why a past scheduled date with other statuses should be treated as PAYOUT_APPROVED.

Copilot uses AI. Check for mistakes.
@@ -7,68 +7,97 @@ Feature: Referral Table Reward Column
And at least one referral exists

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zach Harrison (@zachharrison) feedback for both files. We need a spec or added context to know when our states occur in the UI for testing and documentation. EX: Scenario: The Processing status is displayed if a reward has a connected PFT but the transfer date is in the future.

The logic is just getting more complex now

Copilot AI review requested due to automatic review settings February 11, 2026 00:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 16 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +71 to +74
| Payout Approved | Processing until {date}. Payout is then scheduled based your settings. |
| Payout Failed | Payout failed due to a fulfillment issue and is currently being retried. |
| Payout Cancelled | If you think this is a mistake, contact our Support team. |
| Processing | Processing until {date}. Payout is then scheduled based your settings. |
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example text has a grammatical issue (“based your settings” missing “on”). Update the example copy to match the component’s long-status message so the documentation isn’t misleading.

Suggested change
| Payout Approved | Processing until {date}. Payout is then scheduled based your settings. |
| Payout Failed | Payout failed due to a fulfillment issue and is currently being retried. |
| Payout Cancelled | If you think this is a mistake, contact our Support team. |
| Processing | Processing until {date}. Payout is then scheduled based your settings. |
| Payout Approved | Processing until {date}. Payout is then scheduled based on your settings. |
| Payout Failed | Payout failed due to a fulfillment issue and is currently being retried. |
| Payout Cancelled | If you think this is a mistake, contact our Support team. |
| Processing | Processing until {date}. Payout is then scheduled based on your settings. |

Copilot uses AI. Check for mistakes.
| `payoutApproved` | `payout-approved` | | `string` | `"Payout approved and scheduled for payment based on your settings."` |
| `payoutCancelled` | `payout-cancelled` | | `string` | `"If you think this is a mistake, contact our Support team."` |
| `payoutFailed` | `payout-failed` | | `string` | `"Payout failed due to a fulfillment issue and is current being retried."` |
| `payoutProcessing` | `payout-processing` | | `string` | `"Processing until {date}. Payout is then scheduled based your settings."` |
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated docs list payoutProcessing default as “scheduled based your settings” (missing “on”), which doesn’t match the component default string. Re-generate the readme (or correct the extracted default) so docs match runtime behavior.

Suggested change
| `payoutProcessing` | `payout-processing` | | `string` | `"Processing until {date}. Payout is then scheduled based your settings."` |
| `payoutProcessing` | `payout-processing` | | `string` | `"Processing until {date}. Payout is then scheduled based on your settings."` |

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,289 @@
import { h } from "@stencil/core";
import { ImpactConnection, Reward } from "../../saasquatch";
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import Reward.

Suggested change
import { ImpactConnection, Reward } from "../../saasquatch";
import { ImpactConnection } from "../../saasquatch";

Copilot uses AI. Check for mistakes.
Comment on lines +81 to +83
const payoutSent = {
statuses: ["PAYOUT_APPROVED"],
};
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable payoutSent.

Suggested change
const payoutSent = {
statuses: ["PAYOUT_APPROVED"],
};

Copilot uses AI. Check for mistakes.
Comment on lines +84 to +86
const payoutFailed = {
statuses: ["PAYOUT_FAILED"],
};
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable payoutFailed.

Suggested change
const payoutFailed = {
statuses: ["PAYOUT_FAILED"],
};

Copilot uses AI. Check for mistakes.
Comment on lines +87 to +90
const payoutCancelled = {
statuses: ["PAYOUT_CANCELLED"],
dateCancelled: 1355612521321,
};
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable payoutCancelled.

Suggested change
const payoutCancelled = {
statuses: ["PAYOUT_CANCELLED"],
dateCancelled: 1355612521321,
};

Copilot uses AI. Check for mistakes.
partnerFundsTransfer: null,
};

const cashReward = {
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cashReward.

Suggested change
const cashReward = {
export const cashReward = {

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings February 13, 2026 19:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated 7 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

packages/mint-components/src/components/sqm-rewards-table/columns/sqm-rewards-table-status-column.tsx:152

  • sqm-rewards-table-status-cell introduces a new payoutProcessing text override, but sqm-rewards-table-status-column doesn’t expose/pass through a corresponding prop. That means consumers using the table/column can’t customize the processing message. Add a @Prop() payoutProcessing on the column and pass it into the status cell (and include it in useRequestRerender).
  @Method()
  async renderCell(
    data: Reward,
    options?: { locale: string; taxConnection: ImpactConnection },
  ) {
    return (
      <sqm-rewards-table-status-cell
        statusText={this.statusText}
        reward={data}
        taxConnection={options?.taxConnection}
        expiryText={this.expiryText}
        pendingScheduled={this.pendingScheduled}
        pendingUsTax={this.pendingUsTax}
        pendingUnhandled={this.pendingUnhandled}
        pendingReviewText={this.pendingReviewText}
        payoutFailed={this.payoutFailed}
        payoutApproved={this.payoutApproved}
        payoutCancelled={this.payoutCancelled}
        deniedText={this.deniedText}
        locale={options?.locale}
      ></sqm-rewards-table-status-cell>

packages/mint-components/src/components/sqm-rewards-table/columns/sqm-rewards-table-status-column.tsx:149

  • sqm-rewards-table-status-cell updates the default payoutApproved copy, but this column still passes its own (older) payoutApproved default into the cell, which overrides the new message. If the intent is to change the default payout-approved description (as the updated specs suggest), update the column’s payoutApproved default (or avoid passing it when not explicitly set).
      <sqm-rewards-table-status-cell
        statusText={this.statusText}
        reward={data}
        taxConnection={options?.taxConnection}
        expiryText={this.expiryText}
        pendingScheduled={this.pendingScheduled}
        pendingUsTax={this.pendingUsTax}
        pendingUnhandled={this.pendingUnhandled}
        pendingReviewText={this.pendingReviewText}
        payoutFailed={this.payoutFailed}
        payoutApproved={this.payoutApproved}
        payoutCancelled={this.payoutCancelled}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +108 to +122
Scenario: Payout-related reward statuses are determined by the state of the Paid Funds Transfer
Given a reward exists
And the reward has a connected Paid Funds Transfer (PFT)
When the PFT is in <pftState>
Then the reward's status is <status>
And the status text displays <text>
And the status is displayed in a <pillColour> pill

Examples:
| pftState | status | text | pillColour |
| transfer date is in the future | PAYOUT_PROCESSING | Payment Processing | primary |
| successfully transferred to payment provider | PAYOUT_TRANSFERRED | Payout Approved | primary |
| approved but payout scheduled date not yet arrived | PAYOUT_NOT_YET_DUE | Payout Approved | primary |
| failed due to fulfillment issue and retrying | PAYOUT_OVERDUE | Payout Failed | danger |
| reversed or cancelled after being processed | PAYOUT_REVERSED | Payout Cancelled | danger |
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This spec uses the payout status key PAYOUT_PROCESSING, but the implementation derives PROCESSING for that case (and ICU mappings use PROCESSING). Please align the spec and implementation so the documented status keys match what the components actually emit/expect.

Copilot uses AI. Check for mistakes.
| PAYOUT_NOT_YET_DUE | Payout Approved | primary |
| PAYOUT_OVERDUE | Payout Failed | danger |
| PAYOUT_REVERSED | Payout Cancelled | danger |
| PAYOUT_PROCESSING | Processing | warning |
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature file refers to the status key PAYOUT_PROCESSING, but the component logic/ICU mappings use PROCESSING. Please standardize on one key to keep the specs and customizable status-text ICU format consistent.

Suggested change
| PAYOUT_PROCESSING | Processing | warning |
| PROCESSING | Processing | warning |

Copilot uses AI. Check for mistakes.
Comment on lines 271 to 275
scheduledPayoutDate: reward.partnerFundsTransfer
? DateTime.fromMillis(reward.partnerFundsTransfer.dateScheduled)
?.setLocale(luxonLocale(this.locale))
.toLocaleString(DateTime.DATE_MED)
: null,
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduledPayoutDate is formatted from reward.partnerFundsTransfer.dateScheduled, which is number | null. If it’s null (possible per typings), DateTime.fromMillis(null) will format as the Unix epoch, producing an incorrect date in the UI. Guard for dateScheduled != null before formatting and consider a fallback (e.g., dateTransferred/dateCreated) or omit the date placeholder when unavailable.

Suggested change
scheduledPayoutDate: reward.partnerFundsTransfer
? DateTime.fromMillis(reward.partnerFundsTransfer.dateScheduled)
?.setLocale(luxonLocale(this.locale))
.toLocaleString(DateTime.DATE_MED)
: null,
scheduledPayoutDate:
reward.partnerFundsTransfer &&
reward.partnerFundsTransfer.dateScheduled != null
? DateTime.fromMillis(reward.partnerFundsTransfer.dateScheduled)
.setLocale(luxonLocale(this.locale))
.toLocaleString(DateTime.DATE_MED)
: null,

Copilot uses AI. Check for mistakes.
Comment on lines 114 to 125
if (reward.partnerFundsTransfer.dateScheduled > Date.now()) {
return "PROCESSING";
}

if (
partnerTransferStatus === "TRANSFERRED" ||
partnerTransferStatus === "NOT_YET_DUE" ||
(reward.partnerFundsTransfer.dateScheduled < Date.now() &&
partnerTransferStatus !== "OVERDUE" &&
partnerTransferStatus !== "REVERSED")
)
return "PAYOUT_APPROVED";
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partnerFundsTransfer.dateScheduled is typed as number | null, but it’s compared directly to Date.now(). When dateScheduled is null, JS coerces it to 0, which will incorrectly satisfy < Date.now() and mark the reward as PAYOUT_APPROVED. Add an explicit null check (e.g., dateScheduled != null) before doing these comparisons.

Copilot uses AI. Check for mistakes.
partnerFundsTransfer: null,
};

const cashReward = {
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable cashReward.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 13, 2026 19:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 24 changed files in this pull request and generated 9 comments.

Files not reviewed (1)
  • packages/mint-components/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

packages/mint-components/src/components/sqm-referral-table/cells/sqm-referral-table-rewards-cell.tsx:238

  • Inconsistency between implementation and specification: The feature file specifies that "Payout Processing" status should have a "primary" badge color (line 35), but the implementation returns "warning" for the PROCESSING state (line 238 of the implementation). This needs to be reconciled - either update the implementation to return "primary" or update the feature file to specify "warning".
        case "PENDING_TAX_REVIEW":

packages/mint-components/src/components/sqm-rewards-table/columns/sqm-rewards-table-status-column.tsx:152

  • Missing prop: The payoutProcessing prop is defined in sqm-rewards-table-status-cell (line 95-96 of the cell file) but is not being passed from the column component to the cell component. The cell won't be able to use the customized text for the PROCESSING status. Add payoutProcessing={this.payoutProcessing} to the props being passed to the cell component.
    return (
      <sqm-rewards-table-status-cell
        statusText={this.statusText}
        reward={data}
        taxConnection={options?.taxConnection}
        expiryText={this.expiryText}
        pendingScheduled={this.pendingScheduled}
        pendingUsTax={this.pendingUsTax}
        pendingUnhandled={this.pendingUnhandled}
        pendingReviewText={this.pendingReviewText}
        payoutFailed={this.payoutFailed}
        payoutApproved={this.payoutApproved}
        payoutCancelled={this.payoutCancelled}
        deniedText={this.deniedText}
        locale={options?.locale}
      ></sqm-rewards-table-status-cell>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| transfer date is in the future | PAYOUT_PROCESSING | Processing | warning | Processing until <localized date>. Payout is then scheduled based your settings.|
| successfully transferred to payment provider | PAYOUT_TRANSFERRED | Payout Approved | primary | Payout approved and scheduled for payment based on your settings. |
| approved but payout scheduled date not yet arrived | PAYOUT_NOT_YET_DUE | Payout Approved | primary | Payout approved and scheduled for payment based on your settings. |
| failed due to fulfillment issue and retrying | PAYOUT_OVERDUE | Payout Failed | danger | Payout failed due to a fulfillment issue and is current being retried. |
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "current" should be "currently" in the feature file description

Suggested change
| failed due to fulfillment issue and retrying | PAYOUT_OVERDUE | Payout Failed | danger | Payout failed due to a fulfillment issue and is current being retried. |
| failed due to fulfillment issue and retrying | PAYOUT_OVERDUE | Payout Failed | danger | Payout failed due to a fulfillment issue and is currently being retried. |

Copilot uses AI. Check for mistakes.
| pending reward due to user required to submit a tax document | Submit your tax documents to receive your rewards. |
| pending reward due to tax document being in review | Awaiting tax form review. |
| reward whose payout is processing | Processing until <localized date>. Payout is then scheduled based your settings.|
| reward whose payout failed | Payout failed due to a fulfillment issue and is current being retried. |
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "current" should be "currently" in the feature file description

Suggested change
| reward whose payout failed | Payout failed due to a fulfillment issue and is current being retried. |
| reward whose payout failed | Payout failed due to a fulfillment issue and is currently being retried. |

Copilot uses AI. Check for mistakes.
| pending reward due to an invalid tax document | Invalid tax form. Submit a new form to receive your rewards. |
| pending reward due to user required to submit a tax document | Submit your tax documents to receive your rewards. |
| pending reward due to tax document being in review | Awaiting tax form review. |
| reward whose payout is processing | Processing until <localized date>. Payout is then scheduled based your settings.|
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "based your settings" should be "based on your settings"

Suggested change
| reward whose payout is processing | Processing until <localized date>. Payout is then scheduled based your settings.|
| reward whose payout is processing | Processing until <localized date>. Payout is then scheduled based on your settings.|

Copilot uses AI. Check for mistakes.
"name": "@saasquatch/mint-components",
"title": "Mint Components",
"version": "2.0.10",
"version": "2.0.11",
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider version bump: The PR adds new functionality (PROCESSING status support) which typically warrants a minor version bump (2.1.0) rather than a patch version bump (2.0.11). According to semantic versioning, new features should increment the minor version. However, if this is part of a larger release or there's a specific versioning strategy in place, this may be intentional.

Suggested change
"version": "2.0.11",
"version": "2.1.0",

Copilot uses AI. Check for mistakes.

Examples:
| pftState | status | text | pillColour | description |
| transfer date is in the future | PAYOUT_PROCESSING | Processing | warning | Processing until <localized date>. Payout is then scheduled based your settings.|
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "based your settings" should be "based on your settings"

Suggested change
| transfer date is in the future | PAYOUT_PROCESSING | Processing | warning | Processing until <localized date>. Payout is then scheduled based your settings.|
| transfer date is in the future | PAYOUT_PROCESSING | Processing | warning | Processing until <localized date>. Payout is then scheduled based on your settings.|

Copilot uses AI. Check for mistakes.
"{status, select, AVAILABLE {Available} CANCELLED {Cancelled} PENDING {Pending} PENDING_REVIEW {Pending} PAYOUT_APPROVED {Payout Approved} PAYOUT_CANCELLED {Payout Cancelled} PAYOUT_FAILED {Payout Failed} EXPIRED {Expired} REDEEMED {Redeemed} DENIED {Denied} other {Not available} }";
"{status, select, AVAILABLE {Available} CANCELLED {Cancelled} PENDING {Pending} PENDING_REVIEW {Pending} PAYOUT_APPROVED {Payout Approved} PROCESSING {Processing} PAYOUT_CANCELLED {Payout Cancelled} PAYOUT_FAILED {Payout Failed} EXPIRED {Expired} REDEEMED {Redeemed} DENIED {Denied} other {Not available} }";

/**
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing property definition: The column component needs a payoutProcessing Roman (@prop) to allow customization of the processing status text, similar to other payout status props like payoutFailed, payoutApproved, and payoutCancelled. This should be added after the payoutApproved prop with appropriate JSDoc comments.

Suggested change
/**
/**
* Displayed when a reward payout is processing.
*
* @uiName Payout processing text
*/
@Prop() payoutProcessing: string =
"Your reward payout is currently being processed.";
/**

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants