184994821 reformat scholarships page#21
Conversation
Gekerd patch 1
Scholarships link on home page
Add rspec scholarship
simonjov
left a comment
simonjov
left a comment
There was a problem hiding this comment.
Looks good overall. Please just remove the DS_Stores from the commits and address my other comments and we should be good to merge after that!
There was a problem hiding this comment.
This file should not be added to the commit. You should add it to the .gitignore.
There was a problem hiding this comment.
This file should not be added to the commit. You should add it to the .gitignore.
There was a problem hiding this comment.
This file should not be added to the commit. You should add it to the .gitignore.
There was a problem hiding this comment.
Why are these tests commented out? Please either add a comment explaining this and maybe even a TODO to give guidelines for what future developers can do to fix them or just remove the tests altogether.
There was a problem hiding this comment.
Do I have to close this PR and re-open a new one after I fixed the issues?
|
@simonjov Hey Simon, I just added the DS_Stores to .gitignore, and removed the outdated test |
5 participants
Replaced original styling with simplistic Bootstrap to keep style consistent with rest of app