Feature/better normalization#233
Open
minnerbe wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds per-layer histogram normalization for multisem stacks, mimicking Michal's workflow. It runs at the individual-tile level (before stack assembly), making the whole process very efficient in terms of memory (no stack copy is needed, only filter metadata is written). Additions:
One thing to note: The serialization takes about 1kb, which might add up to a significant amount since it's stored for each tile and it's the same for every tile in a given layer. I have no good intuition about how much the render database can reduce this redundancy automatically, though.