Add support writing to google cloud storage #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Trautman <trautmane@janelia.hhmi.org>
Collaborator
|
Looks good to me - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at #207. I used some of the commits from there as a starting point, which already enabled writing the N5 data to gcp.
In order to not pull N5-universe into render-app, I made
NeuroglancerAtrributes::writetake anN5Writerinstead of a string/URI. Interestingly, this made it much more convenient to use the method in most occurrences, anyway.I checked that writing everything works to the extent that the N5 on gcp can be pointed to and viewed from neuroglancer. Let me know what you think, @trautmane! (Also tagging @StephanPreibisch)