Open
Conversation
98a630c to
d9195c9
Compare
d9195c9 to
761fa5c
Compare
Owner
|
We might need to rejig this once #207 merges as the logic moves away from onLoad to utilising DOMContentLoaded instead |
Author
|
@ryanseddon oh I didn't notice that. Or maybe we don't need this. We manually subscribe |
Author
|
@ryanseddon I've added the commit 85b924e so that this PR won't conflict with #207. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
onLoadis overridden byhandleLoadso does not works.