Skip to content

Conversation

@sungjin-woo
Copy link
Contributor

@sungjin-woo sungjin-woo commented Nov 24, 2017

I realized the properties of basic alert references inside RMUniversalAlert doesn't have memory management attributes.

As you know, the default property attributes with ARC is strong.

@property NSArray *name;
@property (strong, atomic, readwrite) NSArray *name;

I think they don't need to be strong references.
It causes memory leak sometimes since iOS 11.

So, I add weak attribute on the properties.

@property (nonatomic, weak) UIAlertController *alertController;
@property (nonatomic, weak) UIAlertView *alertView;
@property (nonatomic, weak) UIActionSheet *actionSheet;

Could you check this out, please?

- Change references for embeded alert controller, alert and action sheet to weak reference explicitly
@sungjin-woo sungjin-woo changed the title Change embeded alert references Change embeded alert property attributes Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant