Open
Conversation
Input events
Contributor
Author
|
Thinking about it again, I am not sure if introducing lifetimes into the library by letting the Input Manager instance hold a mutable ref to a deck is a good idea, we could just move the deck into the manager, make it public and access it via That would be much easier to use imo. What do you think @ryankurte ? |
Owner
|
hey overall looks good, i think you are correct about it is more straightforward to just pass the deck instance into the manager (so long as it remains optional as not to break existing uses), and if folks have more complex needs we can look at that in the future (or it can be implemented outside the library). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented input events as discussed in #33.
Tested functionality with StreamDeck Plus and Mini.