Skip to content

Fix aws sigv4 calculation for multi byte utf8 characters #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanfowler merged 1 commit into from
Jan 9, 2026
Merged

Fix aws sigv4 calculation for multi byte utf8 characters #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions internal/aws/escape.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,18 @@ func escapeURIPath(w *bytes.Buffer, uri string) {
var buf [utf8.UTFMax]byte
length := utf8.EncodeRune(buf[:], c)

w.WriteByte('%')
encodeHexUpper(w, buf[:length])
for i := range length {
w.WriteByte('%')
encodeHexUpper(w, buf[i])
}
}
w.WriteString(uri[n:])
}

func encodeHexUpper(w *bytes.Buffer, s []byte) {
func encodeHexUpper(w *bytes.Buffer, b byte) {
const hexUpper = "0123456789ABCDEF"
for i := range s {
b := s[i]
w.WriteByte(hexUpper[b>>4])
w.WriteByte(hexUpper[b&0x0F])
}
w.WriteByte(hexUpper[b>>4])
w.WriteByte(hexUpper[b&0x0F])
}

// mapping of valid uri path bytes.
Expand Down