Fetch and save aspect ratio for responsive embeds #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daun
commented
Nov 11, 2016
daun
commented
- Added new column to db: aspect_ratio
- Added method to handle the db schema update
- Fetches width and height from oEmbed to determine video’s aspect ratio for proper responsive embedding
- Added new module config field: defaultAspectRatio (used when aspect ratio can’t be determined from oEmbed request)
- Bumbed version to 112
– Added new column to db: aspect_ratio – Added method to handle the db schema update – Fetches width and height from oEmbed to determine video’s aspect ratio for proper responsive embedding – Added new module config field: defaultAspectRatio (used when aspect ratio can’t be determined from oEmbed request) – Bumbed version to 112
|
I really like this @philippdaun. Can this be merged @ryancramerdesign? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.