HTTPS support #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancramerdesign
added a commit
that referenced
this pull request
Jun 26, 2013
Owner
|
Thanks good idea! I have updated this to support https. |
|
Hey. I fixed my HTTPS embed problem by changing line 86 to: 86. $embedCode = str_replace('http','https',$data['html']);My issue came from the fact that OEmbed service only returns http links even if the url that is fed is using https. This gave errors when embedding on https pages. |
ryancramerdesign
added a commit
that referenced
this pull request
Mar 9, 2014
…time rather than at cache time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page is served over HTTPS, the module should serve videos that way. Both YouTube and Vimeo support using SSL connections for Oembed.
The protocol should probably defined globally at init rather than the hacky way I have done it within each function.