feat(graphics): Phase 5 - Resolution Control and FbInfo Syscall #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configurable framebuffer resolution support: **build.rs:** - Configure bootloader BootConfig with minimum framebuffer dimensions - Default to 1920x1080 for better interactive experience - Resolution overridable via BREENIX_FB_WIDTH/HEIGHT env vars **qemu-uefi.rs:** - Use virtio-vga device in interactive mode for high-res support - virtio-vga supports configurable xres/yres parameters - Headless mode (-nographic) preserved for CI testing - Resolution from BREENIX_FB_WIDTH/HEIGHT passed to QEMU **demo.rs:** - Display current resolution in demo header - Update footer to show "Phase 5: Resolution Control Active" Usage: # Default 1920x1080 cargo run -p xtask -- interactive # Custom resolution BREENIX_FB_WIDTH=2560 BREENIX_FB_HEIGHT=1440 cargo run -p xtask -- interactive Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Phase 5 Resolution Control improvements: - Add sys_fbinfo syscall (410) to query framebuffer info - Add libbreenix graphics module with FbInfo wrapper - Add /sbin/resolution userspace program to display FB info - Fix resolution to 1920x1080 (1920x1200 not in OVMF GOP modes) - Always use virtio-vga for consistent resolution control The FbInfo syscall returns width, height, stride, bytes_per_pixel, and pixel format. Conditionally compiled with interactive feature. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds comprehensive test coverage for the FbInfo syscall: - Add fbinfo_test.rs integration test with assertions - Add boot stage marker for CI validation - Add test execution in kernel test sequence - Add userspace pointer validation (security fix) - Support both interactive and non-interactive modes The test validates: - Syscall returns valid framebuffer dimensions - Width and height are positive - Bytes per pixel is 3 or 4 - Pixel format is valid (RGB/BGR/grayscale) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ryanbreen
force-pushed
the
feature/graphics-phase-4
branch
from
b78c405 to
68b5d86
Compare
With 227 boot stages, CI environments need more time to complete all tests. The previous 180s timeout was causing tests to fail at 217/227 stages. Increased to 300s (5 minutes) for CI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ture The FbInfo struct and USER_SPACE_MAX constant are only used in the interactive version of sys_fbinfo. Adding cfg gates eliminates warnings when building without the interactive feature. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove unused yellow_style variable in demo.rs - Remove unused re-exports from graphics/mod.rs (Font, FontMetrics, FontSize, Glyph, Weight, TextStyle) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Previously, text rendering without an explicit background would just darken the foreground color based on glyph intensity, resulting in poor anti-aliasing against non-black backgrounds. Now the text renderer: - Reads the actual canvas pixel at each glyph position - Properly alpha-blends the foreground color with the existing pixel - Removes the intensity threshold (was skipping low-intensity pixels) This requires adding get_pixel() and buffer() methods to the Canvas trait, and from_pixel_bytes() to Color for reading pixels back. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 of the graphics stack implementation:
Resolution Control: Configure framebuffer resolution via QEMU virtio-vga
BREENIX_FB_WIDTH/BREENIX_FB_HEIGHTenv varsFbInfo Syscall (410): Query framebuffer information from userspace
libbreenix graphics module: Userspace wrapper for graphics syscalls
FbInfostruct matching kernel ABIfbinfo()function with proper error handlingUtilities:
/sbin/resolution: Display current framebuffer infofbinfo_test: Integration test with boot stage markerTest plan
🤖 Generated with Claude Code