Skip to content

Fix to #790: Ping errors solved. #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TreadTheDawnGames wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Fix to #790: Ping errors solved. #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f160f53
Ping errors solved
TreadTheDawnGames Nov 17, 2025
edec51e
Remove '.testing' from about
TreadTheDawnGames Nov 17, 2025
83728c5
Remove unused 'using'
TreadTheDawnGames Nov 17, 2025
51fc08d
Remove debug logs
TreadTheDawnGames Nov 17, 2025
39c7fd5
Formatting
TreadTheDawnGames Nov 17, 2025
68c8802
Remove spaces at file ending.
TreadTheDawnGames Nov 17, 2025
9f7e9b3
Formatting
TreadTheDawnGames Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Source/Client/UI/DrawPingPlanet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ static void Postfix()
var tileCenter = GenWorldUI.WorldToUIPosition(Find.WorldGrid.GetTileCenter(ping.planetTile));
const float size = 30f;

ping.DrawAt(tileCenter, player.color, size);
//Only draw pings for layers that are on the layer we're at or lower
if (PlanetLayer.Selected.layerId >= ping.planetTile.layerId)
ping.DrawAt(tileCenter, player.color, size);
}
}
}
Expand Down
9 changes: 8 additions & 1 deletion Source/Client/UI/LocationPings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,14 @@ public void UpdatePing()
if (MultiplayerStatic.PingKeyDef.JustPressed || KeyDown(Multiplayer.settings.sendPingButton))
{
if (WorldRendererUtility.WorldSelected)
PingLocation(-1, GenWorld.MouseTile(), Vector3.zero);
{
//Get the tile under the mouse and snap it to the nearest valid item. (i.e. An asteroid if in space, etc)
var mouseTile = GenWorld.MouseTile(true);

//If the tileId == -1, mouseTile is invalid (i.e. the mouse is over ocean or in space) and out of range.
if (mouseTile.tileId != -1)
PingLocation(-1, mouseTile, Vector3.zero);
}
else if (Find.CurrentMap != null)
PingLocation(Find.CurrentMap.uniqueID, 0, UI.MouseMapPosition());
}
Expand Down