Introduce ServerDisconnectPacket #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mibac138
force-pushed
the
disconnect-packet
branch
from
b0c9b70 to
88ea4e8
Compare
notfood
added
enhancement
Provides a cleaner way of dealing with common packets across different connection states
Reduces reliance on a LiteNetLib-specific feature, unifies disconnection process across different transports, and allows to arbitrarily evolve the new typed packet.
mibac138
force-pushed
the
disconnect-packet
branch
from
88ea4e8 to
91d1af3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces reliance on a LiteNetLib-specific feature, unifies disconnection
process across different transports, and allows to arbitrarily evolve
the new typed packet.
Requires #772 because the current LiteNetLib version throws an exception when a NetPeer is disconnected during polling events.
Requires #776 to reduce merge conflicts.