Fix for #539 and refactor async quest management into modular system #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for: rwmt#539 Resolved the issue in the quest cache system by introducing a removal list that's processed after each async tick on the map. And I started refactoring the async quest handling with the following goals in mind: - Removed reliance on static quest cache data. - Reorganized logic into non-static classes for better maintainability. - Added a QuestManagerAsync, modeled after RimWorld’s source code. - Abstracted the dependency on AsyncTimeComp via an interface — with the idea that time handling might eventually be tied to factions or players across maps. - Simplified and clarified some complex LINQ queries. - Aimed to make the code more expressive and easier to follow. - Added TODOs for items discovered during testing. Cheers
notfood
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
The work is still in progress, but I'm opening this draft PR to avoid losing any changes — and in case someone else wants to pick it up. I'm pausing contributions for now and will check back in once Zetrith returns. 👍
Fix #539: Resolved the issue in the quest cache system by introducing a removal list that's processed after each async tick on the map.
And I started refactoring the async quest handling with the following goals in mind:
Cheers! :)