Add advisory for onig Region heap buffer overflow#2918
Open
cuiwenhao123 wants to merge 1 commit into
Open
Conversation
Member
|
Please use the pull request template. |
Contributor
Author
|
Updated the PR description to use the pull request template. |
Member
|
I don't see approval from the maintainer(s) to publish an advisory anywhere? |
Contributor
Author
|
Confirmed there is no explicit upstream maintainer approval yet. I asked the rust-onig maintainers here: rust-onig/rust-onig#215 (comment) I will leave the checklist item unchecked until they confirm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
onig(10,583,261 recent downloads per crates.io)Links to upstream issue(s) or PR(s)
Severity
Affected versions expose a memory-safety issue in the safe
RegionAPI.Region::reserve()andRegion::with_capacity()cast a user-providedusizecapacity toc_intbefore calling the Oniguruma C API. Very large capacities can wrap to a negativec_int, causing a small allocation whileRegion::len()later interprets the stored value as a largeusize. A subsequentRegion::pos()call can then perform an out-of-bounds heap read.This can lead to memory exposure and violates Rust safety expectations for safe APIs. The issue is fixed in
onig6.5.2 by checking theusizetoc_intconversion inRegion::reserve().Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure dateValidation
rustsec-admin lintLint advisoriespassed