Skip to content

provide with_platform_verifier_and_extra_roots extension function #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
conradludgate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

provide with_platform_verifier_and_extra_roots extension function #204

conradludgate wants to merge 1 commit into from

Conversation

@conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Jan 2, 2026

Fixes #202

@djc
Copy link
Member

djc commented Jan 2, 2026

No extra roots on Android... maybe an extension trait method that yields some kind of builder which only offers to set extra roots on non-Android?

@conradludgate conradludgate force-pushed the with_extra_roots-ext branch 2 times, most recently from 0bd0573 to c1de987 Compare January 3, 2026 12:51
@conradludgate
Copy link
Contributor Author

conradludgate commented Jan 3, 2026 •
edited
Loading

The android/ios tests failing seems to be unrelated. The semver error is correct, but I feel like it is not significant here - no one should be using dyn BuilderVerifierExt.

@conradludgate

This comment has been minimized.

Sign in to view
complexspaces
complexspaces approved these changes Jan 3, 2026
View reviewed changes
Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I agree the technical semver breakage shouldn't be important. I have a really hard time seeing anyone using the extension traits in their own type declarations since there's only one implementation of each anyway.

@complexspaces
Copy link
Collaborator

complexspaces commented Jan 3, 2026

I assume if we merge this the cargo-semver-checks job will start to ignore this past "breakage" on future PRs and go back to being green?

@djc
Copy link
Member

djc commented Jan 3, 2026

Probably only after we release.

@complexspaces
Copy link
Collaborator

complexspaces commented Jan 16, 2026

Should we go ahead and merge this and then release next week? We have enough changes in main to make a new one IMO.

@djc
Copy link
Member

djc commented Jan 16, 2026

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@complexspaces complexspaces complexspaces approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

with_extra_roots extension

3 participants

@conradludgate @djc @complexspaces