Open
Conversation
Member
|
I think this needs test coverage before it could be reviewed for merge. |
Author
|
Added in some test cases. Was a bit unsure on location / method since we can't serialize basic constraints currently. Made the csr test cases with openssl and documented the commands used |
djc
reviewed
Mar 24, 2026
Reuse in IsCa's x509 constructor
Update CSR Params from_der documentation to reference Basic Constraints support
5Dev24
force-pushed
the
csr-params-is-ca
branch
from
7d0c62a to
2e474ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add in support for Basic Constraints in CSR Params parsing from DER.
Split out the logic used in
IsCa::from_x509so we can use the same logic when parsing.Done as some CSRs contain basic constraints and
CertificateSigningRequestParams::from_{pem,der}fails to parse them.