Skip to content

Fix nginx websocket and keepalive support #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jstangroome wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix nginx websocket and keepalive support #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions docs/integration/nginx.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ upstream rustfs-console {
server 127.0.0.1:9001;
}

map $http_upgrade $proxy_set_header_connection {
# If the Upgrade request header is present, also send a `Connection: upgrade` request header upstream,
# otherwise prevent the default `Connection: close` request header being sent to preserve keepalives.
default "upgrade";
"" "";
}

server {
listen 80;
Expand Down Expand Up @@ -59,14 +65,10 @@ server {
proxy_connect_timeout 300;
# Default is HTTP/1, keepalive is only enabled in HTTP/1.1
proxy_http_version 1.1;
proxy_set_header Connection "";
chunked_transfer_encoding off;

proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";



proxy_set_header Connection $proxy_set_header_connection;

proxy_pass http://rustfs; # This uses the upstream directive definition to load balance
}
Expand Down Expand Up @@ -99,14 +101,10 @@ server {
proxy_connect_timeout 300;
# Default is HTTP/1, keepalive is only enabled in HTTP/1.1
proxy_http_version 1.1;
proxy_set_header Connection "";
chunked_transfer_encoding off;

proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";



proxy_set_header Connection $proxy_set_header_connection;

proxy_pass http://rustfs-console; # This uses the upstream directive definition to load balance
}
Expand Down Expand Up @@ -149,6 +147,13 @@ Console: `www.rustfs.dev`


~~~
map $http_upgrade $proxy_set_header_connection {
# If the Upgrade request header is present, send a `Connection: upgrade` request header upstream,
# otherwise prevent the default `Connection: close` request header being sent to preserve keepalives.
default "upgrade";
"" "";
}

server {
listen 443;
listen [::]:443;
Expand All @@ -175,11 +180,10 @@ server {
proxy_connect_timeout 300;
# Default is HTTP/1, keepalive is only enabled in HTTP/1.1
proxy_http_version 1.1;
proxy_set_header Connection "";
chunked_transfer_encoding off;

proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";
proxy_set_header Connection $proxy_set_header_connection;

proxy_pass http://127.0.0.1:9000;
}
Expand All @@ -195,12 +199,12 @@ server {
proxy_connect_timeout 300;
# Default is HTTP/1, keepalive is only enabled in HTTP/1.1
proxy_http_version 1.1;
proxy_set_header Connection "";
chunked_transfer_encoding off;

proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection "upgrade";
proxy_set_header Connection $proxy_set_header_connection;

proxy_pass http://127.0.0.1:9001;
}
}
~~~
~~~