Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes recursive rm --purge behavior by ensuring each object under a prefix is force-deleted via single-object delete requests (matching RustFS semantics), and updates a CORS stdin integration test assertion to match the existing camelCase JSON output contract.
Changes:
- Route recursive purge deletes through
delete_single(one request per key) instead of the batch delete path. - Update CORS integration test to assert
allowedMethodsrather thanallowed_methodsin JSON output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/cli/tests/integration.rs | Adjusts CORS JSON assertion to use the camelCase allowedMethods field. |
| crates/cli/src/commands/rm.rs | Adds a dedicated recursive --purge path that deletes keys individually via the single-object delete API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ca7d5fe to
4459f0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rm --purgethrough single-object delete requests so RustFS applies force-delete semantics to each object.Evidence
bucket_operations::test_bucket_cors_set_accepts_stdin_sourceandversion_operations::test_rm_recursive_purge_permanently_deletes_versioned_prefix.rustfs/rustfs:latestusing an isolated RustFS container.version liststill showed delete markers and original versions because the batch delete path did not purge versions on latest RustFS.Safety
Validation
cargo test --package rustfs-cli --test integration --features integration bucket_operations::test_bucket_cors_set_accepts_stdin_source -- --exact --test-threads=1cargo test --package rustfs-cli --test integration --features integration version_operations::test_rm_recursive_purge_permanently_deletes_versioned_prefix -- --exact --test-threads=1cargo test --package rustfs-cli --test integration --features integration -- --test-threads=1make pre-commit