Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CLI integration coverage for the rc admin decommission workflow (including the decom alias) and hardens the admin test TCP server helper to avoid a nonblocking-read race during full test runs.
Changes:
- Added new non-Windows integration tests covering
admin decommission start,admin decommission status, andadmin decom cancel, asserting JSON output and the dispatched admin route/method/query. - Fixed the
admin_rebalancetest server helper by switching the accepted socket back to blocking mode before reading the request.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/cli/tests/admin_rebalance.rs | Ensures the accepted TCP stream is blocking before request parsing to prevent flaky nonblocking reads. |
| crates/cli/tests/admin_decommission.rs | New integration tests verifying CLI dispatch/aliasing and JSON output for the decommission admin workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds focused CLI integration coverage for the admin decommission workflow introduced with pool decommissioning support.
Background
The lower-level admin client already had route tests for decommission start and cancel, and the CLI parser covered the command shapes. The missing path was the real
rc admin decommissionbinary dispatch through alias resolution, JSON output formatting, and signed admin route selection.Changes
admin decommission start,admin decommission status, and theadmin decom cancelalias.Validation
cargo fmt --all --checkcargo test -p rustfs-cli --test admin_decommissioncargo test -p rustfs-cli --test admin_rebalance --test admin_decommissionmake pre-commit