update dependencies, drop time dependency, fix compiler and clippy warnings #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy has been is shipped as part of the Rust toolchain instead of as a separate crate for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm one of the maintainers of the package for this crate in Fedora Linux. We carry some downstream patches that I thought would make sense to submit here.
While I was at it, I ported things from
time::Instantandtime::Durationtostd::time::{Instant, Duration}as recommended by the deprecation notices intimev0.3, and fixed compiler warnings and clippy warnings / errors.Note that since
timewas part of the public API, dropping it is a breaking change, so if you want to publish this, it should probably be as version 2.0.0. I tried runningcargo-semver-checksto verify this, but it cannot even parse v1.0.0 of this crate because of the clippy plugin usage 😬Note that I also found some potential soundness bugs when running
cargo miri test, should I report those separately?