-
-
Notifications
You must be signed in to change notification settings - Fork 486
Update rand_core to 0.10.0-rc-4 #1712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a6f1f5 to
dc9d6e6
Compare
dc9d6e6 to
6830af0
Compare
|
0.10.0-rc-5 (see rust-random/rand_core#51) is published, maybe better to update to that? |
|
RC5 has no breaking changes over this. |
baloo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in a couple of downstream crates. No issues found
|
Hmm, shouldn't both the |
|
Yeah they should all be compatible, just noting you merged old version numbers |
|
Yes, I saw no need to update; the code should be compatible with both versions (on your advice not to pin the version). |
|
Any chance to get another release candidate of Would ease things up for consumers. |
CHANGELOG.mdentrySummary
Update regarding these rand_core PRs:
RngCore: TryRngCore<Error = Infallible>rand_core#45Unresolved
chacha20
rand_chacha test failure (likely due to rust-random/rand_core#44)