Skip to content

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Jan 19, 2026

  • Added a CHANGELOG.md entry

Summary

Update regarding these rand_core PRs:

Unresolved

chacha20

rand_chacha test failure (likely due to rust-random/rand_core#44)

@dhardy dhardy force-pushed the push-nzsxxkozrnpy branch from 1a6f1f5 to dc9d6e6 Compare January 20, 2026 12:01
@dhardy dhardy force-pushed the push-nzsxxkozrnpy branch from dc9d6e6 to 6830af0 Compare January 20, 2026 12:14
@dhardy dhardy marked this pull request as ready for review January 20, 2026 12:20
@Fethbita
Copy link

0.10.0-rc-5 (see rust-random/rand_core#51) is published, maybe better to update to that?

@dhardy
Copy link
Member Author

dhardy commented Jan 20, 2026

RC5 has no breaking changes over this.

Copy link
Contributor

@baloo baloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a couple of downstream crates. No issues found

@dhardy dhardy merged commit 9c99d93 into master Jan 20, 2026
15 checks passed
@dhardy dhardy deleted the push-nzsxxkozrnpy branch January 20, 2026 16:04
@tarcieri
Copy link
Contributor

Hmm, shouldn't both the rand_core and chacha20 dependencies be bumped?

@dhardy
Copy link
Member Author

dhardy commented Jan 20, 2026

@tarcieri dependabot has done this: #1713.

I don't think we need to bump the numbers in Cargo.toml since we opted to allow this type of update.

@tarcieri
Copy link
Contributor

Yeah they should all be compatible, just noting you merged old version numbers

@dhardy
Copy link
Member Author

dhardy commented Jan 20, 2026

Yes, I saw no need to update; the code should be compatible with both versions (on your advice not to pin the version).

@baloo
Copy link
Contributor

baloo commented Jan 20, 2026

Any chance to get another release candidate of rand?

Would ease things up for consumers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants