Skip to content

Add function on RouteMessageBuilder for setting route MTU #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkusPettersson98 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add function on RouteMessageBuilder for setting route MTU #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/route/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ use netlink_packet_route::route::{
use netlink_packet_route::{
route::{
RouteAddress, RouteAttribute, RouteFlags, RouteHeader, RouteMessage,
RouteNextHop, RouteNextHopFlags, RouteProtocol, RouteScope, RouteType,
RouteVia,
RouteMetric, RouteNextHop, RouteNextHopFlags, RouteProtocol,
RouteScope, RouteType, RouteVia,
},
AddressFamily,
};
Expand Down Expand Up @@ -103,6 +103,14 @@ impl<T> RouteMessageBuilder<T> {
self
}

/// Sets the route mtu (metric)
pub fn mtu(mut self, mtu: u32) -> Self {
self.message
.attributes
.push(RouteAttribute::Metrics(vec![RouteMetric::Mtu(mtu)]));
Copy link
Member

@cathay4t cathay4t Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This override future changes to other RouteMetric (e.g. cwnd).

Please create similar stuff like RouteNextHopBuilder

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't quite understand the solution you are suggestion. Should I create something like a RouteMetricsBuilder inspired by RouteNextHopBuilder?

Copy link
Member

@cathay4t cathay4t Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. RouteMetricsBuilder is required. Otherwise, it is impossible to configure both cwnd and mtu.

self
}

/// Sets the route table ID.
///
/// Default is main route table.
Expand Down