perf(auth): reuse a shared reqwest::Client#158
Open
SVilgelm wants to merge 1 commit into
Open
Conversation
OAuth discovery, metadata, and JWKS/introspection/userinfo fetches each built a fresh Client (new pool + TLS config) per call. Share one process-wide client so requests reuse the connection pool, which matters under concurrent key-rotation verifications. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
OAuth discovery, metadata, and JWKS/introspection/userinfo fetches each constructed a new
reqwest::Clientper call, creating a fresh connection pool and TLS configuration every time. They now share one process-wide client, so requests reuse the connection pool — which matters during key-rotation events with many concurrent verifications.🔍 Related Issues
✨ Changes Made
auth::shared_http_client()backed by aLazyLock<reqwest::Client>.GenericOauthTokenVerifier(replacing per-callClient::new()/reqwest::get).