fix(tls): install rustls crypto provider before serving#156
Open
SVilgelm wants to merge 1 commit into
Open
Conversation
Explicitly install the aws-lc-rs rustls CryptoProvider in start_ssl so the first TLS handshake cannot panic when both aws-lc-rs and ring are present in the dependency graph. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
No rustls
CryptoProviderwas installed explicitly. With bothaws-lc-rs(pulled byjsonwebtoken) andringpotentially in the dependency graph, rustls has no unambiguous default and the first TLS handshake can panic. Thesslpath now installs theaws-lc-rsprovider before serving.🔍 Related Issues
✨ Changes Made
rustlsas an optional dependency under thesslfeature.aws_lc_rsCryptoProviderat the start ofstart_ssl(ignoring the already-installed case so embedders can install their own).