perf(session): shard the in-memory session store lock#154
Open
SVilgelm wants to merge 2 commits into
Open
Conversation
Add a max-session cap (default 10k) and optional idle TTL with lazy eviction. New sessions past the cap are rejected with 503, preventing memory exhaustion via repeated initialize requests. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
Replace the single global RwLock<HashMap> with 16 independently locked shards, reducing contention on the session dispatch path under load. Trait surface unchanged. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
The in-memory session store guarded every operation with a single global
RwLock, serializing the dispatch path under many concurrent clients. Sessions are now spread across 16 independently locked shards so requests for different sessions rarely contend. TheSessionStoretrait surface is unchanged.🔍 Related Issues
✨ Changes Made
RwLock<HashMap>with a 16-way sharded map keyed by session-id hash.get/set/delete/hasacross shards; aggregatekeys/values/eviction across all shards.