fix(transport): cap stdio line length#151
Open
SVilgelm wants to merge 1 commit into
Open
Conversation
Replace the unbounded line reader with a capped reader (4 MiB) that drops over-long messages and resyncs, preventing unbounded buffering from a hostile peer. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
The stdio reader used
AsyncBufReadExt::lines(), which buffers until a newline with no limit, so a peer streaming data without\ncould force unbounded memory growth. Incoming lines are now capped; an over-long message is dropped (resynced to the next newline) and logged, keeping the stream alive.🔍 Related Issues
✨ Changes Made
lines()with a cappedfill_buf/consumereader (4 MiB limit).