Add commit message diff in our range-diff implementation#2422
Merged
Conversation
Urgau
force-pushed
the
gh-range-diff-commits
branch
from
951ec46 to
0618555
Compare
Kobzol
reviewed
May 31, 2026
| #[derive(Debug, serde::Deserialize)] | ||
| pub struct GitUser { | ||
| pub date: DateTime<FixedOffset>, | ||
| pub name: String, |
Member
There was a problem hiding this comment.
I think that at least the e-mail can be missing (https://docs.rs/octocrab/latest/octocrab/models/struct.SimpleUser.html#structfield.name). I definitely ran into this in bors. I'd perhaps make both an Option, but definitely the e-mail should be an Option.
Member
Author
There was a problem hiding this comment.
Tbh, I'm not even sure having the author and email is that useful.
Member
Author
There was a problem hiding this comment.
Alright, I made both optional.
Member
There was a problem hiding this comment.
I think the message is the most important thing in the diff, yeah.
Urgau
force-pushed
the
gh-range-diff-commits
branch
from
0618555 to
5188615
Compare
Kobzol
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been mentioned to me by multiple people that they would like to see the different commit messages in our range-diff, like is done in the official
git range-diff.This PR therefore adds such feature. It's not exactly the same, as we show the changes across the full range, and not per commit as is done by
git range-diff.As such I added a new section called "Commits" which list all the commits and the diff if there is a change in the message.
Testing links:
Best reviewed commit by commit.
cc @camelid