LogStorage: fix log limits (lines/length/size) with multi-line log msgs#134
Merged
Conversation
Skgland
reviewed
May 21, 2026
Comment on lines
+193
to
+196
| let mut length = max_line_length - 3; | ||
| while !message.is_char_boundary(length) { | ||
| length -= 1; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| let mut length = max_line_length - 3; | |
| while !message.is_char_boundary(length) { | |
| length -= 1; | |
| } | |
| let length = message.floor_char_boundary(max_line_length - 3); |
Could this use str::floor_char_boundary or is this newer than rustwides msrv?
Member
Author
There was a problem hiding this comment.
we currently have 1.89 in there, that method case with 1.91.
I feel like this is not reason enough to push the msrv?
Contributor
There was a problem hiding this comment.
Ok, sounds reasonable to not bump the msrv for just this.
Member
Author
There was a problem hiding this comment.
I'm also always wondering how many real-world users outside of the rust org actually exist, so if the msrv la really important to them
GuillaumeGomez
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coming from rust-lang/docs.rs#3346 I realized that we assume that one log message is only one log line.
But we also get single log-messages with multi-line content.
So this PR goes through the log message line by line.