Add unstable Share trait#156828
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
SimonSapin
reviewed
May 23, 2026
Contributor
|
@bors r+ rollup Additions are unstable and match https://rust-lang.github.io/rust-project-goals/2026/ergonomic-rc.html#the-share-trait |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
May 23, 2026
…=SimonSapin Add unstable Share trait Tracking issue: rust-lang#156756 This adds an initial unstable `Share` trait for clone-as-alias types, as part of the 2026 ergonomic ref-counting project goal. ```rust pub trait Share: Clone { fn share(&self) -> Self { Clone::clone(self) } } ``` This PR adds a separate unstable feature gate: ```rust #![feature(share_trait)] ``` and places the trait next to `Clone` in `core::clone`. Implemented initial impls: - `impl<T: ?Sized> Share for &T` - `impl<T: ?Sized, A: Allocator + Clone> Share for Rc<T, A>` - `impl<T: ?Sized, A: Allocator + Clone> Share for Arc<T, A>` - `impl<T> Share for std::sync::mpsc::Sender<T>` - `impl<T> Share for std::sync::mpsc::SyncSender<T>` The PR deliberately does not add `Share` to the prelude. r? @nikomatsakis @rustbot label F-ergonomic_clones
rust-bors Bot
pushed a commit
that referenced
this pull request
May 24, 2026
…uwer Rollup of 6 pull requests Successful merges: - #156769 (Use print instead of po in debuginfo path test) - #156784 (Fix reborrow_info early return skipping field validation) - #156827 (float_literal_f32_fallback: Don't suggest invalid code) - #156828 (Add unstable Share trait) - #156830 (Add `#[doc(alias = "phi")]` for float `GOLDEN_RATIO` constants) - #156860 (Fix Pieter-Louis Schoeman mailmap entry)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #156756
This adds an initial unstable
Sharetrait for clone-as-alias types, as part of the 2026 ergonomic ref-counting project goal.This PR adds a separate unstable feature gate:
#![feature(share_trait)]and places the trait next to
Cloneincore::clone.Implemented initial impls:
impl<T: ?Sized> Share for &Timpl<T: ?Sized, A: Allocator + Clone> Share for Rc<T, A>impl<T: ?Sized, A: Allocator + Clone> Share for Arc<T, A>impl<T> Share for std::sync::mpsc::Sender<T>impl<T> Share for std::sync::mpsc::SyncSender<T>The PR deliberately does not add
Shareto the prelude.r? @nikomatsakis
@rustbot label F-ergonomic_clones