Skip to content

Simplify how coroutine transform and shims handle nested derefs#156422

Open
cjgillot wants to merge 3 commits into
rust-lang:mainfrom
cjgillot:coroutine-deref
Open

Simplify how coroutine transform and shims handle nested derefs#156422
cjgillot wants to merge 3 commits into
rust-lang:mainfrom
cjgillot:coroutine-deref

Conversation

@cjgillot
Copy link
Copy Markdown
Contributor

These are a few simplifications I stumbled upon while working on #146562.

The first commit is purely cosmetic.
The second commit handles an early return where deref_finder was not run, ICEing in validate-mir.
The third commit replaces an open-coded version of deref_finder with a call to that method.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 11, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 11, 2026

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir, mir-opt
  • compiler, mir, mir-opt expanded to 73 candidates
  • Random selection from 18 candidates

@rust-log-analyzer

This comment has been minimized.

@folkertdev
Copy link
Copy Markdown
Contributor

r? wg-mir-opt

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 22, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants