Skip to content

Move tests codegen#156195

Open
danieljofficial wants to merge 2 commits intorust-lang:mainfrom
danieljofficial:move-tests-codegen
Open

Move tests codegen#156195
danieljofficial wants to merge 2 commits intorust-lang:mainfrom
danieljofficial:move-tests-codegen

Conversation

@danieljofficial
Copy link
Copy Markdown
Contributor

@danieljofficial danieljofficial commented May 5, 2026

Hi, I have moved some tests into the codegen folder

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 5, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 5, 2026

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented May 5, 2026

The codegen directory is meant for tests that check the produced LLVM IR. None of the tests you moved contain checks for this. All these tests do the testing by getting executed and not crashing. Codegen tests are never executed.

@danieljofficial
Copy link
Copy Markdown
Contributor Author

danieljofficial commented May 5, 2026

The codegen directory is meant for tests that check the produced LLVM IR. None of the tests you moved contain checks for this. All these tests do the testing by getting executed and not crashing. Codegen tests are never executed.

Oh wow, I did not know this. I categorized them based on the comments left and the issues I read. Meaning each of these might belong in completely different separate folders? Do you know of any other folders with a similar directive, or is there any documentation about the test folders that might be helpful to me? If I am being very honest, there are a lot of issues I read that I do not understand at all, maybe because the code is from a very old version of rust or I just dont have the knowledge so I have to rely on keywords for categorizing. Hence, I miss subtle conventions like this.

@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented May 5, 2026

Please ignore my previous comment. I misread tests/ui/codegen as tests/codegen. The former is still for ui tests as these tests need to be. The later is for codegen tests.

@danieljofficial
Copy link
Copy Markdown
Contributor Author

danieljofficial commented May 5, 2026

Please ignore my previous comment. I misread tests/ui/codegen as tests/codegen. The former is still for ui tests as these tests need to be. The later is for codegen tests.

Alright.

JohnTitor
JohnTitor approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 6, 2026

📌 Commit 769c3a9 has been approved by JohnTitor

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request May 6, 2026
@jhpratt
Rollup merge of rust-lang#156195 - danieljofficial:move-tests-codegen…
f8a77e2 
…, r=JohnTitor

Move tests codegen

Hi, I have moved some tests into the codegen folder
@jhpratt jhpratt mentioned this pull request May 6, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request May 6, 2026
@bors
Auto merge of #156217 - jhpratt:rollup-XVslat0, r=jhpratt
3f0e976 
Rollup of 15 pull requests

Successful merges:

 - #151122 (fix: more descriptive error message for enum to integer)
 - #155341 (generic_const_args: allow paths to non type consts)
 - #156062 (Added command-line argument support for `wasm32-wali-linux-musl`)
 - #156159 ([AIX] add -bdbg:namedsects:ss link arg)
 - #156174 (Wasm: remove implicit `__heap_base`/`__data_end` exports)
 - #156186 (fix: remap ci-llvm debug paths via `-ffile-prefix-map`)
 - #156193 (port `rustc_ast*` crates from `box_` to `deref_patterns`)
 - #156201 (Don't run ui-fulldeps tests twice in stage 1)
 - #155808 (Always use `ConstFn` context for `const` closures)
 - #156105 (interpret: correctly deal with repr(transparent) enums)
 - #156148 (Use `all_impls` instead of handrolling it)
 - #156156 (Adjust getMCSubtargetInfo signature for LLVM 23+)
 - #156170 (add known-bug test for coroutine 'static-yields-non-'static unsoundness (#144442))
 - #156195 (Move tests codegen)
 - #156205 (move generalization test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danieljofficial @rustbot @bjorn3 @JohnTitor