Skip to content

Migrate libraries from ptr::slice_from_raw_parts to .cast_slice#156109

Open
Paladynee wants to merge 1 commit intorust-lang:mainfrom
Paladynee:lib/cast-slice-improvements
Open

Migrate libraries from ptr::slice_from_raw_parts to .cast_slice#156109
Paladynee wants to merge 1 commit intorust-lang:mainfrom
Paladynee:lib/cast-slice-improvements

Conversation

@Paladynee
Copy link
Copy Markdown
Contributor

@Paladynee Paladynee commented May 3, 2026

Tracking issue for #![feature(ptr_cast_slice)]: #149103
This commit updates most callsites of ptr::slice_from_raw_parts within ./library to the more concise but unstable postfix .cast_slice() method on raw pointers, using the ptr_cast_slice feature. Some tests in alloctests have also been updated.

No functional change, debatably improved readability.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 3, 2026

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added O-SGX Target: SGX S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 3, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 3, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt, nia-e

@Paladynee
Copy link
Copy Markdown
Contributor Author

some notable places like core::slice::from_raw_parts have not been updated, because i felt like changing that would harm readability than improving it.

@rust-log-analyzer

This comment has been minimized.

@Paladynee
Copy link
Copy Markdown
Contributor Author

hmm wait let me revert that doc change, apparently it is exactly the same in std::ptr::slice_from_raw_parts. this is all so confusing since all the names are super similar lol

@rust-log-analyzer

This comment has been minimized.

@Paladynee Paladynee force-pushed the lib/cast-slice-improvements branch 3 times, most recently from 5533d7b to fced58f Compare May 3, 2026 15:10
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented May 3, 2026

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented May 4, 2026

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

Aside from this, r=me

@jhpratt
Copy link
Copy Markdown
Member

jhpratt commented May 4, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 4, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Paladynee
Copy link
Copy Markdown
Contributor Author

Paladynee commented May 4, 2026

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

i believe they are equivalent other than the debug UB assertion, yes

@Paladynee
Copy link
Copy Markdown
Contributor Author

Paladynee commented May 4, 2026

I'm not touching anything in;

  • coretests
  • core::slice
  • any ptr::slice_from_raw_parts{_mut} call in stable documentations
  • believe i can revert the stdarch thing since it seems too complicated for me to change for now

with that, i think this pr is ready

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2026
@Paladynee Paladynee force-pushed the lib/cast-slice-improvements branch from fced58f to e030a3f Compare May 4, 2026 17:33
@xtqqczze
Copy link
Copy Markdown
Contributor

xtqqczze commented May 5, 2026

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

The library/core/src/slice/sort/shared/smallsort.rs changes should be reverted as they conflict with #156192.

@Paladynee Paladynee force-pushed the lib/cast-slice-improvements branch from e030a3f to 14315f9 Compare May 6, 2026 01:47
@Paladynee
Copy link
Copy Markdown
Contributor Author

Could &*ptr::slice_from_raw_parts be written as slice::from_raw_parts?

The library/core/src/slice/sort/shared/smallsort.rs changes should be reverted as they conflict with #156192.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-SGX Target: SGX S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants