std: implement sleep_until for Fuchsia#152617
Conversation
|
Hey friends of Fuchsia! This issue could use some guidance on how this should be |
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
|
Sorry for the delay here. I was on vacation, then out sick for a bit. The implementation looks correct to me. Thank you for updating the One nit on the commit comment: while most usages of |
2e608fb to
8e4293c
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
8e4293c to
a31064a
Compare
Tracking issue: #113752
Unfortunately Fuchsia's
clock_nanosleepis only a stub. The kernel'szx_nanosleepsyscall however does exactly what's needed.I've done a few drive-by changes in the two outer commits, our uses of
zx_time_tuse thezx_instant_mono_talias nowadays and the syscall table in thesleep_untildocumentation didn't mark the function names as code.@rustbot ping fuchsia