-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
compiletest: Parse aux proc-macro directive into struct
#151670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
To minimize the diff when adding features the aux `proc-macro` directive.
be7b3f2 to
30e41de
Compare
proc-pacro directive into structproc-macro directive into struct
| } | ||
|
|
||
| /// The value of a `proc-macro` directive. | ||
| #[derive(Clone, Debug, Default)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: These structs shouldn't actually need to be Default, but I'm fine with merging this as-is (since it matches the others) and then fixing all of them in a separate follow-up PR.
|
Thanks for splitting these up; it makes reviewing each part much nicer. @bors r+ rollup |
compiletest: Parse aux `proc-macro` directive into struct This PR does not introduce any changes. It is pure refactoring to make PR rust-lang#151258 smaller so it is easier to see what that PR is about, as discussed [here](rust-lang#151258 (comment)). r? @Zalathar
Rollup merge of #151670 - Enselic:proc-macro-struct, r=Zalathar compiletest: Parse aux `proc-macro` directive into struct This PR does not introduce any changes. It is pure refactoring to make PR #151258 smaller so it is easier to see what that PR is about, as discussed [here](#151258 (comment)). r? @Zalathar
This PR does not introduce any changes. It is pure refactoring to make PR #151258 smaller so it is easier to see what that PR is about, as discussed here.
r? @Zalathar