Skip to content

Conversation

@Enselic
Copy link
Member

@Enselic Enselic commented Jan 26, 2026

This PR does not introduce any changes. It is pure refactoring to make PR #151258 smaller so it is easier to see what that PR is about, as discussed here.

r? @Zalathar

@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2026

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 26, 2026
To minimize the diff when adding features the aux `proc-macro`
directive.
@Enselic Enselic changed the title compiletest: Parse aux proc-pacro directive into struct compiletest: Parse aux proc-macro directive into struct Jan 26, 2026
}

/// The value of a `proc-macro` directive.
#[derive(Clone, Debug, Default)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: These structs shouldn't actually need to be Default, but I'm fine with merging this as-is (since it matches the others) and then fixing all of them in a separate follow-up PR.

@Zalathar
Copy link
Member

Thanks for splitting these up; it makes reviewing each part much nicer.

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 26, 2026

📌 Commit 30e41de has been approved by Zalathar

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2026
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
Rollup of 2 pull requests

Successful merges:

 - #151612 (Update documentation for `cold_path`, `likely`, and `unlikely`)
 - #151670 (compiletest: Parse aux `proc-macro` directive into struct)
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 26, 2026
compiletest: Parse aux `proc-macro` directive into struct

This PR does not introduce any changes. It is pure refactoring to make PR rust-lang#151258 smaller so it is easier to see what that PR is about, as discussed [here](rust-lang#151258 (comment)).

r? @Zalathar
@rust-bors rust-bors bot merged commit 43b955a into rust-lang:main Jan 26, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 26, 2026
Rollup merge of #151670 - Enselic:proc-macro-struct, r=Zalathar

compiletest: Parse aux `proc-macro` directive into struct

This PR does not introduce any changes. It is pure refactoring to make PR #151258 smaller so it is easier to see what that PR is about, as discussed [here](#151258 (comment)).

r? @Zalathar
@rustbot rustbot added this to the 1.95.0 milestone Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants