Cleanup offload datatransfer #151640
Open
Cleanup offload datatransfer #151640
+105
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
ZuseZ4
commented
Jan 25, 2026
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
2 times, most recently
from
d9def93 to
4f29cbe
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
4f29cbe to
014d61d
Compare
ZuseZ4
force-pushed
the
cleanup-datatransfer
branch
from
014d61d to
6b45680
Compare
rustbot
added
S-waiting-on-review
Member
Author
|
I don't think jieyouxu will want to review this part of rustc. |
Collaborator
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 steps to run code on a GPU: Copy data from the host to the device, launch the kernel, and move it back.
At the moment, we have a single variable describing the memory handling to do in each step, but that makes it hard for LLVM's opt pass to understand what's going on. We therefore split it into three variables, each only including the bits relevant for the corresponding stage.
cc @jdoerfert @kevinsala
r? compiler