mGCA: Make trait object types with type-level associated consts dyn compatible if all of the latter are specified via bindings #150843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
added
T-compiler
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. This PR modifies |
rustbot
added
A-LLVM
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Jan 8, 2026
mGCA: Make trait object types with type associated consts dyn compatible if the latter are specified via bindings
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Jan 8, 2026
mGCA: Make trait object types with type associated consts dyn compatible if the latter are specified via bindings
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
fmease
changed the title
Contributor
rust-bors
bot
added
S-waiting-on-bors
...but require all assoc consts to be specified via bindings.
We used to lower such bad defaulted const args in trait object types to
`{type error}`; now correctly lower them to `{const error}`.
The added tests used to ICE prior to this change.
…would otherwise ref `Self` The added test used to ICE prior to this change.
This fully rewords the diagnostic that was previously only emitted for assoc ty bindings. That's because it incorrectly called trait aliases *type aliases* and didn't really make it clear what the root cause is. The added test used to ICE prior to this change. I've double-checked that the preexisting test I've modified still ICEs in nightly-2025-03-29.
… `Self` (barring `Self` projections)
rust-bors
bot
added
S-waiting-on-author
Contributor
|
|
Member
Author
|
Small tweak post rebase. @bors r=BoxyUwU |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Member
Author
Contributor
|
(I think the norm is to make all rollups p=5, putting yourself above that is reasonable, I'll create the rollup if more rollup=always pop up) |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
mGCA: Make trait object types with type-level associated consts dyn compatible if all of the latter are specified via bindings Under feature `min_generic_const_args` (mGCA) (#132980), render traits with non-parametrized type-level associated constants (i.e., `#[type_const]` ones) dyn compatible but force the user to specify all type-level associated consts in the trait object type via bindings (either directly, via supertrait bounds and/or behind trait aliases) just like associated types, their sibling. Fixes #130300 (feature request). Fixes #136063 (bug). Fixes #137260 (bug). Fixes #137514 (bug). While I'm accounting for most illegal `Self` references via const projections & params, I'm intentionally ignoring RUST-123140 (and duplicates) in this PR which is to be tackled some other time. Additional context: Crate `rustc-demangle` had to be updated to fix v0 demangling. I've patched it in PR rust-lang/rustc-demangle#87 which was was released in version 0.1.27 via PR rust-lang/rustc-demangle#88.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for 22663dd failed: CI. Failed job:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under feature
min_generic_const_args(mGCA) (#132980), render traits with non-parametrized type-level associated constants (i.e.,#[type_const]ones) dyn compatible but force the user to specify all type-level associated consts in the trait object type via bindings (either directly, via supertrait bounds and/or behind trait aliases) just like associated types, their sibling.Fixes #130300 (feature request).
Fixes #136063 (bug).
Fixes #137260 (bug).
Fixes #137514 (bug).
While I'm accounting for most illegal
Selfreferences via const projections & params, I'm intentionally ignoring RUST-123140 (and duplicates) in this PR which is to be tackled some other time.Additional context: Crate
rustc-demanglehad to be updated to fix v0 demangling. I've patched it in PR rust-lang/rustc-demangle#87 which was was released in version 0.1.27 via PR rust-lang/rustc-demangle#88.