Drop the From derive macro from the v1 prelude #150203
Open
+0
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This was accidentally added to the prelude in 3f4dc1e.
jtgeibel
force-pushed
the
drop-From-derive-macro-from-prelude
branch
from
372672a to
93fbf3b
Compare
Member
|
It was added in #144922 as a part of implementation this feature So as far as I understand it shouldn't be removed r? Kobzol |
Collaborator
|
|
Contributor
|
No I think it got removed from the prelude again because of the shadowing bug demonstrated right there. My addition was just a rebasing bug. @Kobzol r=me if that's true |
Member
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Kivooeo
added a commit
to Kivooeo/rust
that referenced
this pull request
Dec 20, 2025
…om-prelude, r=jdonszelmann Drop the From derive macro from the v1 prelude This was accidentally added to the prelude in 3f4dc1e. Fixes: rust-lang#150165 r? `@jdonszelmann`
bors
added a commit
that referenced
this pull request
Dec 20, 2025
Rollup of 7 pull requests Successful merges: - #147552 ([Debugger Visualizers] Optimize lookup behavior) - #149437 (Fix trailing newline in JUnit formatter) - #149812 (Add const default for OnceCell and OnceLock) - #150035 (fix docustring on fetch_or) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) r? `@ghost` `@rustbot` modify labels: rollup
Kivooeo
added a commit
to Kivooeo/rust
that referenced
this pull request
Dec 20, 2025
…om-prelude, r=jdonszelmann Drop the From derive macro from the v1 prelude This was accidentally added to the prelude in 3f4dc1e. Fixes: rust-lang#150165 r? `@jdonszelmann`
bors
added a commit
that referenced
this pull request
Dec 21, 2025
Rollup of 6 pull requests Successful merges: - #149437 (Fix trailing newline in JUnit formatter) - #149812 (Add const default for OnceCell and OnceLock) - #150035 (fix docustring on fetch_or) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 21, 2025
…om-prelude, r=jdonszelmann Drop the From derive macro from the v1 prelude This was accidentally added to the prelude in 3f4dc1e. Fixes: rust-lang#150165 r? ``@jdonszelmann``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally added to the prelude in 3f4dc1e.
Fixes: #150165
r? @jdonszelmann