Skip to content

Conversation

@tbu-
Copy link
Contributor

@tbu- tbu- commented Dec 8, 2025

I don't know why many places refer to the type as crate::io::Result when crate::io is already imported.

@rustbot rustbot added O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@tbu- tbu- force-pushed the pr_crate_io_result branch from 99eb90b to 09e39c6 Compare December 8, 2025 17:46
@tbu-
Copy link
Contributor Author

tbu- commented Dec 8, 2025

How do I verify that I haven't broken all of these targets that the CI doesn't check?

@bors
Copy link
Collaborator

bors commented Dec 9, 2025

☔ The latest upstream changes (presumably #147572) made this pull request unmergeable. Please resolve the merge conflicts.

@ChrisDenton
Copy link
Member

How do I verify that I haven't broken all of these targets that the CI doesn't check?

Something like:

./x build library/std --target x86_64-fortanix-unknown-sgx,x86_64-unknown-hermit

@tbu- tbu- force-pushed the pr_crate_io_result branch from 09e39c6 to 0fe1555 Compare December 10, 2025 06:35
@rustbot rustbot added the O-wasi Operating system: Wasi, Webassembly System Interface label Dec 10, 2025
@rustbot

This comment has been minimized.

@tbu- tbu- force-pushed the pr_crate_io_result branch from 0fe1555 to ca641b4 Compare December 10, 2025 06:37
@Mark-Simulacrum
Copy link
Member

@bors try jobs=dist-various-*

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 13, 2025
`crate::io::Result` → `io::Result` in most places

try-job: dist-various-*
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Dec 13, 2025

💔 Test for 866d786 failed: CI. Failed jobs:

@bors
Copy link
Collaborator

bors commented Dec 15, 2025

☔ The latest upstream changes (presumably #149930) made this pull request unmergeable. Please resolve the merge conflicts.

@tbu- tbu- force-pushed the pr_crate_io_result branch from ca641b4 to 363e0da Compare December 16, 2025 10:58
@rustbot rustbot added the O-itron Operating System: ITRON label Dec 16, 2025
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
@tbu- tbu- force-pushed the pr_crate_io_result branch from 363e0da to 8dd8140 Compare December 16, 2025 11:00
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
-use crate::fmt;
-use crate::io;
+use crate::{fmt, io};
 
 /// Wraps a μITRON error code.
 #[derive(Debug, Copy, Clone)]
Diff in /checkout/library/std/src/sys/pal/sgx/abi/usercalls/mod.rs:214:
                 true
             }
             Err(e) => {
-                rtassert!(e.kind() == io::ErrorKind::TimedOut || e.kind() == io::ErrorKind::WouldBlock);
+                rtassert!(
+                    e.kind() == io::ErrorKind::TimedOut || e.kind() == io::ErrorKind::WouldBlock
+                );
                 false
             }
         }
fmt: checked 6600 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants