[WIP] resolve: Make ambiguity checking stricter#149145
Closed
petrochenkov wants to merge 1 commit into
Closed
Conversation
rustbot
added
S-waiting-on-review
Collaborator
Contributor
Author
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
added a commit
that referenced
this pull request
Nov 20, 2025
[WIP] resolve: Make ambiguity checking stricter
petrochenkov
added
S-waiting-on-crater
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
💔 Test for 0e7f93c failed: CI. Failed jobs:
|
petrochenkov
force-pushed
the
visambig
branch
from
bf5f878 to
58af356
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors try |
rust-bors Bot
added a commit
that referenced
this pull request
Nov 20, 2025
[WIP] resolve: Make ambiguity checking stricter
This comment has been minimized.
This comment has been minimized.
Contributor
Contributor
Author
|
@craterbot check |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
Collaborator
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
Collaborator
|
🎉 Experiment
Footnotes
|
craterbot
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (presumably #149462) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
force-pushed
the
visambig
branch
from
58af356 to
27839b2
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Closing in favor of #149596. |
rustbot
removed
the
S-waiting-on-author
waywardmonkeys
added a commit
to waywardmonkeys/bevy-vello
that referenced
this pull request
May 22, 2026
With a current Rust, you get this warning: ``` warning: ambiguous import visibility: pub or pub(crate) --> src/lib.rs:21:9 | 21 | pub use vello; | ^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #149145 <rust-lang/rust#149145> = note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution = note: `vello` could refer to a crate passed with `--extern` = help: use `::vello` to refer to this crate unambiguously note: `vello` could also refer to the crate imported here --> src/lib.rs:5:5 | 5 | use crate::prelude::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `vello` to disambiguate = help: or use `crate::vello` to refer to this crate unambiguously = note: `#[warn(ambiguous_import_visibilities)]` (part of `#[warn(future_incompatible)]`) on by default warning: `bevy_vello` (lib) generated 1 warning ```
waywardmonkeys
added a commit
to waywardmonkeys/bevy-vello
that referenced
this pull request
May 22, 2026
With a current Rust, you get this warning: ``` warning: ambiguous import visibility: pub or pub(crate) --> src/lib.rs:21:9 | 21 | pub use vello; | ^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #149145 <rust-lang/rust#149145> = note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution = note: `vello` could refer to a crate passed with `--extern` = help: use `::vello` to refer to this crate unambiguously note: `vello` could also refer to the crate imported here --> src/lib.rs:5:5 | 5 | use crate::prelude::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `vello` to disambiguate = help: or use `crate::vello` to refer to this crate unambiguously = note: `#[warn(ambiguous_import_visibilities)]` (part of `#[warn(future_incompatible)]`) on by default warning: `bevy_vello` (lib) generated 1 warning ```
waywardmonkeys
added a commit
to waywardmonkeys/bevy-vello
that referenced
this pull request
May 22, 2026
With a current Rust, you get this warning: ``` warning: ambiguous import visibility: pub or pub(crate) --> src/lib.rs:21:9 | 21 | pub use vello; | ^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #149145 <rust-lang/rust#149145> = note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution = note: `vello` could refer to a crate passed with `--extern` = help: use `::vello` to refer to this crate unambiguously note: `vello` could also refer to the crate imported here --> src/lib.rs:5:5 | 5 | use crate::prelude::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `vello` to disambiguate = help: or use `crate::vello` to refer to this crate unambiguously = note: `#[warn(ambiguous_import_visibilities)]` (part of `#[warn(future_incompatible)]`) on by default warning: `bevy_vello` (lib) generated 1 warning ```
waywardmonkeys
added a commit
to waywardmonkeys/bevy-vello
that referenced
this pull request
May 22, 2026
With a current Rust, you get this warning: ``` warning: ambiguous import visibility: pub or pub(crate) --> src/lib.rs:21:9 | 21 | pub use vello; | ^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #149145 <rust-lang/rust#149145> = note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution = note: `vello` could refer to a crate passed with `--extern` = help: use `::vello` to refer to this crate unambiguously note: `vello` could also refer to the crate imported here --> src/lib.rs:5:5 | 5 | use crate::prelude::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `vello` to disambiguate = help: or use `crate::vello` to refer to this crate unambiguously = note: `#[warn(ambiguous_import_visibilities)]` (part of `#[warn(future_incompatible)]`) on by default warning: `bevy_vello` (lib) generated 1 warning ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing a possible proper fix for the
RustEmbedissue (#147196).cc @LorrensP-2158466