Rollup of 12 pull requests by matthiaskrgr · Pull Request #137959 · rust-lang/rust

matthiaskrgr · 2025-03-03T19:47:18Z

Successful merges:

Future incompatibility warning unsupported_fn_ptr_calling_conventions: Also warn in dependencies #135767 (Future incompatibility warning unsupported_fn_ptr_calling_conventions: Also warn in dependencies)
Remove layouting dead code for non-array SIMD types. #137852 (Remove layouting dead code for non-array SIMD types.)
Fix pretty printing of unsafe binders #137863 (Fix pretty printing of unsafe binders)
do not build additional stage on compiler paths #137882 (do not build additional stage on compiler paths)
Revert "store ScalarPair via memset when one side is undef and the other side can be memset" #137894 (Revert "store ScalarPair via memset when one side is undef and the other side can be memset")
Make ast::TokenKind more like lexer::TokenKind #137902 (Make ast::TokenKind more like lexer::TokenKind)
Subtree update of rust-analyzer #137921 (Subtree update of rust-analyzer)
A few cleanups after the removal of cfg(not(parallel)) #137922 (A few cleanups after the removal of cfg(not(parallel)))
fix order on shl impl #137939 (fix order on shl impl)
Fix docker run-local docs #137946 (Fix docker run-local docs)
Always allow rustdoc-json tests to contain long lines #137955 (Always allow rustdoc-json tests to contain long lines)
triagebot.toml: Don't label test/rustdoc-json as A-rustdoc-search #137958 (triagebot.toml: Don't label test/rustdoc-json as A-rustdoc-search)

r? @ghost
@rustbot modify labels: rollup

Also fix the `needs_drop()` intrinsic. Unions also need this information (to err if they have a drop-needing field), but this will come in a follow-up PR.

Don't filter out private items when completing paths in the same crate. Instead respect the `privateEditable` setting. Fixes rust-lang#9850

…wn-linux-gnueabihf builds

internal: Downgrade to ubuntu-22.04 for aarch64 and arm builds

Fix `event_name` check is workflows

Disable incremental on release builds

feat: update insta inline snapshot when clicking 'Update Test' runnable

Include private items in completions for local crates

Vendor `always-assert` into `stdx`

feat: Calculate drop glue and show it on hover

…n-assist internal: Migrate `apply_demorgan` to `SyntaxEditor`

…pl-tabstop minor: Add tabstop to impl body in `generate_trait_impl` assist

We vendor the list of implications, which isn't nice, but t-compiler doesn't want to make rustc_target available to us.

…t-feature fix: Support target features implications in target_feature 1.1

matthiaskrgr · 2025-03-03T19:48:14Z

@bors r+ rollup=never p=5

bors · 2025-03-03T19:48:17Z

📌 Commit 5d093cb has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-03-04T02:28:01Z

⌛ Testing commit 5d093cb with merge fd17dea...

bors · 2025-03-04T05:47:34Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing fd17dea to master...

rust-timer · 2025-03-04T05:51:08Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#135767	Future incompatibility warning `unsupported_fn_ptr_calling_…	`d1345760e13b19391a5d174462263267ce75fb0f` (link)
#137852	Remove layouting dead code for non-array SIMD types.	`b437d695772c83037a97fb391769ed8adf4b4e51` (link)
#137863	Fix pretty printing of unsafe binders	`ff5cc4317d849f7d5c6c54a09f8b65638f9b6206` (link)
#137882	do not build additional stage on compiler paths	`c384b7f1d1cc002d2ebfb27719438b9fd3d4ab4a` (link)
#137894	Revert "store ScalarPair via memset when one side is undef …	`b8307b31525a395bb642819fa226ecdfcf562115` (link)
#137902	Make `ast::TokenKind` more like `lexer::TokenKind`	`02b730e010fdc5ff9ba8173ac0fd2d9398fecc91` (link)
#137921	Subtree update of `rust-analyzer`	`5b3a7166420e970a2bf322664eef70228de136e2` (link)
#137922	A few cleanups after the removal of `cfg(not(parallel))`	`f746ea293132b5a73a514bcca95242f8b6e332bf` (link)
#137939	fix order on shl impl	`498a85d18f221ce21993dd96e981901d64e96d12` (link)
#137946	Fix docker run-local docs	`f13cfac309f5b90131e57845c39e037523c962c0` (link)
#137955	Always allow rustdoc-json tests to contain long lines	`d7de8308d14fec3ce7f5104fab0c0f957d7e36e1` (link)
#137958	triagebot.toml: Don't label `test/rustdoc-json` as A-rustdo…	`844d8f0e8e0d8e147213834b46f41a77dd87213a` (link)

previous master: 2010bba886

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-03-04T06:50:03Z

Finished benchmarking commit (fd17dea): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 0.9%, secondary 8.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.8%, 1.0%]	4
Regressions ❌ (secondary)	8.7%	[7.8%, 9.7%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.8%, 1.0%]	4

Binary size

Results (primary 0.1%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	58
Regressions ❌ (secondary)	0.1%	[0.0%, 0.4%]	15
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	8
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	10
All ❌✅ (primary)	0.1%	[-0.1%, 0.2%]	66

Bootstrap: missing data
Artifact size: 362.03 MiB -> 362.04 MiB (0.00%)

…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#135767 (Future incompatibility warning `unsupported_fn_ptr_calling_conventions`: Also warn in dependencies) - rust-lang#137852 (Remove layouting dead code for non-array SIMD types.) - rust-lang#137863 (Fix pretty printing of unsafe binders) - rust-lang#137882 (do not build additional stage on compiler paths) - rust-lang#137894 (Revert "store ScalarPair via memset when one side is undef and the other side can be memset") - rust-lang#137902 (Make `ast::TokenKind` more like `lexer::TokenKind`) - rust-lang#137921 (Subtree update of `rust-analyzer`) - rust-lang#137922 (A few cleanups after the removal of `cfg(not(parallel))`) - rust-lang#137939 (fix order on shl impl) - rust-lang#137946 (Fix docker run-local docs) - rust-lang#137955 (Always allow rustdoc-json tests to contain long lines) - rust-lang#137958 (triagebot.toml: Don't label `test/rustdoc-json` as A-rustdoc-search) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 12 pull requests Successful merges: - #135767 (Future incompatibility warning `unsupported_fn_ptr_calling_conventions`: Also warn in dependencies) - #137852 (Remove layouting dead code for non-array SIMD types.) - #137863 (Fix pretty printing of unsafe binders) - #137882 (do not build additional stage on compiler paths) - #137894 (Revert "store ScalarPair via memset when one side is undef and the other side can be memset") - #137902 (Make `ast::TokenKind` more like `lexer::TokenKind`) - #137921 (Subtree update of `rust-analyzer`) - #137922 (A few cleanups after the removal of `cfg(not(parallel))`) - #137939 (fix order on shl impl) - #137946 (Fix docker run-local docs) - #137955 (Always allow rustdoc-json tests to contain long lines) - #137958 (triagebot.toml: Don't label `test/rustdoc-json` as A-rustdoc-search) r? `@ghost` `@rustbot` modify labels: rollup

ChayimFriedman2 and others added 30 commits February 17, 2025 06:29

Calculate drop glue and show it on hover

d1fb18e

Also fix the `needs_drop()` intrinsic. Unions also need this information (to err if they have a drop-needing field), but this will come in a follow-up PR.

feat: update insta inline snapshot when clicks 'Update Test' runnable

629fa76

fix

2b6ea13

Allow "package/feature" format feature flag

a0c69fd

Include private items in completions for local crates

4ab9329

Don't filter out private items when completing paths in the same crate. Instead respect the `privateEditable` setting. Fixes rust-lang#9850

Downgrade to ubuntu-22.04 for aarch64-unknown-linux-gnu and arm-unkno…

e2a7731

…wn-linux-gnueabihf builds

Fix event_name check in workflows

5397431

Merge pull request rust-lang#19216 from lnicola/ubuntu-22.04

dac3460

internal: Downgrade to ubuntu-22.04 for aarch64 and arm builds

Merge pull request rust-lang#19217 from lnicola/event-name

af83f2f

Fix `event_name` check is workflows

Disable incremental on release builds

7bba76e

Vendor always-assert

d761f9b

Merge pull request rust-lang#19218 from Veykril/push-vqsronpuvrnx

a4bd32c

Disable incremental on release builds

Merge pull request rust-lang#19197 from andylokandy/insta

49116c6

feat: update insta inline snapshot when clicking 'Update Test' runnable

Merge pull request rust-lang#19211 from Timmmm/user/timh/import_private

6e2abbf

Include private items in completions for local crates

Merge pull request rust-lang#19219 from Veykril/push-rvosplwpwqqt

18c6f22

Vendor `always-assert` into `stdx`

Migrate some leftovers in add_missing_match_arms

67a99a3

Migrate apply_demorgan to SyntaxEditor

756f213

Add take() method to SyntaxEditor

1c2225b

Merge pull request rust-lang#18987 from ChayimFriedman2/drop-glue

32e4049

feat: Calculate drop glue and show it on hover

Merge pull request rust-lang#19171 from ShoyuVanilla/migrate-de-morga…

a9dbd49

…n-assist internal: Migrate `apply_demorgan` to `SyntaxEditor`

minor: Add tabstop to impl body in generate_trait_impl assist

1ff2593

Merge pull request rust-lang#19221 from Giga-Bowser/generate-trait-im…

e6bb047

…pl-tabstop minor: Add tabstop to impl body in `generate_trait_impl` assist

doc: remove nit from setup.md

91ff420

Support target features implications in target_feature 1.1

d5a85af

We vendor the list of implications, which isn't nice, but t-compiler doesn't want to make rustc_target available to us.

Disable typos checker for the target feature names

5c654dc

Merge pull request rust-lang#19223 from ChayimFriedman2/implied-targe…

16402de

…t-feature fix: Support target features implications in target_feature 1.1

internal: Improve reporting of intersecting changes

f7adafc

internal: Migrate remove_mut assist to SyntaxEditor

cac5153

internal: Migrate remove_parentheses assist to SyntaxEditor

8036e84

fix: Properly handle removals in SyntaxEditor

1d5f831

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2025

bors merged commit fd17dea into rust-lang:master Mar 4, 2025

rustbot added this to the 1.87.0 milestone Mar 4, 2025

This was referenced Mar 4, 2025

Ergonomic ref counting #134797

Merged

Convert ShardedHashMap to use hashbrown::HashTable #137701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 12 pull requests#137959

Rollup of 12 pull requests#137959
bors merged 110 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-62vjvwr

matthiaskrgr commented Mar 3, 2025

Uh oh!

matthiaskrgr commented Mar 3, 2025

Uh oh!

bors commented Mar 3, 2025

Uh oh!

bors commented Mar 4, 2025

Uh oh!

bors commented Mar 4, 2025

Uh oh!

rust-timer commented Mar 4, 2025

Uh oh!

rust-timer commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

matthiaskrgr commented Mar 3, 2025

Uh oh!

matthiaskrgr commented Mar 3, 2025

Uh oh!

bors commented Mar 3, 2025

Uh oh!

bors commented Mar 4, 2025

Uh oh!

bors commented Mar 4, 2025

Uh oh!

rust-timer commented Mar 4, 2025

Uh oh!

rust-timer commented Mar 4, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants