-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Enable Miri to pass pointers through FFI #129684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri The Miri subtree was changed cc @rust-lang/miri |
|
Oh. Well that didn't work yet. |
| @@ -1 +1,2 @@ | |||
| printing from C | |||
| printing pointer dereference from C: 42 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This comment has been minimized.
This comment has been minimized.
|
(I might quickly try to enhance+refactor the C pointer FFI tests in Miri now.) |
dcdb101 to
6e23a4d
Compare
RalfJung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks! Just got some nits regarding the tests.
|
Please squash the commits, then we can land this. :-) |
Co-authored-by: Ralf Jung <post@ralfj.de>
730bd97 to
7fde02e
Compare
|
Great, congrats on getting this finished! @bors r+ |
Following #126787, the purpose of this PR is to now enable Miri to execute native calls that make use of pointers.
Note that this PR does not yet implement any logic involved in updating Miri's "analysis" state (byte initialization, provenance) upon such a native call.
r? @RalfJung