fix ICE when asm_const and const_refs_to_static are combined

[folkertdev]

fixes #129462
fixes #126896
fixes #124164

I think this is a case that was missed in the fix for #125558, which inserts a type error in the case of an invalid (that is, non-integer) type being passed to an asm const operand.

I'm not 100% sure that span_mirbug_and_err is the right macro here, but it is used earlier with builtin_deref and seems to do the trick.

r? @lcnr

[oli-obk]

I think this should be fixing a buch of known other ICEs, too. Try running the crashes test suite

[folkertdev]

no luck there

> ./x test --keep-stage 1 tests/crashes/

running 232 tests
........................................................................................  88/232
........................................................................................ 176/232
........................................................

test result: ok. 232 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5.63s

[lcnr]

I think that maybe we want to do it for all signatures, i.e. assign this match to a variable and then check whether that variable has any error_reported. I expect that to fix even more issues 😁

I am otherwise quite happy with this change

[folkertdev]

no further crashes are fixed by that change. I did rename #129952 to reflect that the tainting now occurs in a different place.

[lcnr]

thanks for your patience and good work ❤️

@bors r+ rollup

[bors]

📌 Commit 49e3b9a has been approved by lcnr

It is now in the queue for this repository.