Add unused_format_specs lint#9637
Merged
Merged
Conversation
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #9600) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
force-pushed
the
unused-format-specs
branch
from
52fa719 to
87de785
Compare
xFrednet
approved these changes
Oct 17, 2022
Contributor
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
Looks good to me, two small doc adjustments and one question. Then you can r=me 🙃
flip1995
reviewed
Oct 17, 2022
Alexendoo
force-pushed
the
unused-format-specs
branch
from
87de785 to
5343b0d
Compare
Alexendoo
force-pushed
the
unused-format-specs
branch
from
5343b0d to
136c2cd
Compare
Contributor
|
Thanks! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently catches two cases:
An empty precision specifier:
And using formatting specs on
format_args!():changelog: new lint: [
unused_format_specs]