Don't report missing safety doc for #[target_feature(enable)] attributed functions#17051
Open
DJMcNab wants to merge 3 commits into
Open
Don't report missing safety doc for #[target_feature(enable)] attributed functions#17051DJMcNab wants to merge 3 commits into
#[target_feature(enable)] attributed functions#17051DJMcNab wants to merge 3 commits into
Conversation
Collaborator
|
Some changes occurred in clippy_lints/src/doc cc @notriddle |
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
notriddle
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog:
missing_safety_doc: No longer applies for#[target_feature(enable)]attributes functions.As of Rust 1.86, these functions are safe to call in a context with the specified target features already enabled. I asked Ralf at RustWeek, who thought that these functions probably shouldn't require a safety comment. However, Clippy currently requires this with
missing_safety_doc. This PR removes the warning in that case.I also wrote a version which is MSRV aware version, which handled the MSRV change. This is the first commit of this branch. I don't think this is the correct implementation, but I have it for discussion. For this, the changelog would be:
missing_safety_doc: No longer applies for#[target_feature(enable)]attributes functions if your MSRV has target features 1.1.