Fix race condition in clang_macro_fallback#3369
Open
HKalbasi wants to merge 1 commit intorust-lang:mainfrom
Open
Fix race condition in clang_macro_fallback#3369HKalbasi wants to merge 1 commit intorust-lang:mainfrom
HKalbasi wants to merge 1 commit intorust-lang:mainfrom
Conversation
46 tasks
emilio
reviewed
May 5, 2026
| use crate::ir::context::BindgenContext; | ||
| use clang_sys::*; | ||
| use std::cmp; | ||
| use std::os::unix::ffi::OsStrExt; |
Contributor
There was a problem hiding this comment.
This probably needs to be #[cfg]d to build on windows right?
| } | ||
|
|
||
| fn path_to_cstring(path: &Path) -> CString { | ||
| CString::new(path.as_os_str().as_bytes()).unwrap() |
Contributor
There was a problem hiding this comment.
Yeah this probably needs something else on windows right?
Member
Author
There was a problem hiding this comment.
Would path.to_string_lossy().as_bytes() be fine? tmpfile crate probably generates utf8 paths.
Member
Author
There was a problem hiding this comment.
Btw shouldn't a windows CI be there to catch this?
HKalbasi
force-pushed
the
fix-race-condition
branch
from
d1bc925 to
8cd1b34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resurrection of #3111
Github does not allow reopening force pushed PRs.